net/quic/chromium/quic_stream_factory.cc - Issue 2250473007: Move UseNonBlockingIO from a windows-only method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_stream_factory.cc

Issue 2250473007: Move UseNonBlockingIO from a windows-only method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: socket_host_udp_unittest.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_stream_factory.cc

diff --git a/net/quic/chromium/quic_stream_factory.cc b/net/quic/chromium/quic_stream_factory.cc

index e99a35be865a5d92570d4366dcb578e2cb8f7c11..6e32c7bde5ed60b4d707dacfd99bd3c995d36b29 100644

--- a/net/quic/chromium/quic_stream_factory.cc

+++ b/net/quic/chromium/quic_stream_factory.cc

@@ -1700,12 +1700,8 @@ bool QuicStreamFactory::HasActiveCertVerifierJob(

int QuicStreamFactory::ConfigureSocket(DatagramClientSocket* socket,

IPEndPoint addr,

NetworkHandle network) {

- if (enable_non_blocking_io_ &&

- client_socket_factory_ == ClientSocketFactory::GetDefaultFactory()) {

-#if defined(OS_WIN)

- static_cast<UDPClientSocket*>(socket)->UseNonBlockingIO();

-#endif

- }

+ if (enable_non_blocking_io_)

+ socket->UseNonBlockingIO();

int rv;

if (migrate_sessions_on_network_change_) {

« no previous file with comments | « net/dns/mock_mdns_socket_factory.h ('k') | net/socket/socket_test_util.h » ('j') | no next file with comments »