src/heap/heap.cc - Issue 2250423002: [heap] Don't unmap new space pages while sweeping is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 2250423002: [heap] Don't unmap new space pages while sweeping is active (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 9d6204df2a53974b81b37bb965a1ae2f288aa7ea..4a48fadb2245665ce982c6e9a93205b9f20263b9 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -1595,8 +1595,6 @@ void Heap::Scavenge() {

// Pause the inline allocation steps.

PauseAllocationObserversScope pause_observers(this);

- mark_compact_collector()->sweeper().EnsureNewSpaceCompleted();

gc_state_ = SCAVENGE;

// Implements Cheney's copying algorithm

« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »