Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: src/heap/heap.cc

Issue 2250423002: [heap] Don't unmap new space pages while sweeping is active (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/ast/context-slot-cache.h" 9 #include "src/ast/context-slot-cache.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 1577 matching lines...) Expand 10 before | Expand all | Expand 10 after
1588 RelocationLock relocation_lock(this); 1588 RelocationLock relocation_lock(this);
1589 // There are soft limits in the allocation code, designed to trigger a mark 1589 // There are soft limits in the allocation code, designed to trigger a mark
1590 // sweep collection by failing allocations. There is no sense in trying to 1590 // sweep collection by failing allocations. There is no sense in trying to
1591 // trigger one during scavenge: scavenges allocation should always succeed. 1591 // trigger one during scavenge: scavenges allocation should always succeed.
1592 AlwaysAllocateScope scope(isolate()); 1592 AlwaysAllocateScope scope(isolate());
1593 1593
1594 // Bump-pointer allocations done during scavenge are not real allocations. 1594 // Bump-pointer allocations done during scavenge are not real allocations.
1595 // Pause the inline allocation steps. 1595 // Pause the inline allocation steps.
1596 PauseAllocationObserversScope pause_observers(this); 1596 PauseAllocationObserversScope pause_observers(this);
1597 1597
1598 mark_compact_collector()->sweeper().EnsureNewSpaceCompleted();
1599
1600 gc_state_ = SCAVENGE; 1598 gc_state_ = SCAVENGE;
1601 1599
1602 // Implements Cheney's copying algorithm 1600 // Implements Cheney's copying algorithm
1603 LOG(isolate_, ResourceEvent("scavenge", "begin")); 1601 LOG(isolate_, ResourceEvent("scavenge", "begin"));
1604 1602
1605 // Used for updating survived_since_last_expansion_ at function end. 1603 // Used for updating survived_since_last_expansion_ at function end.
1606 intptr_t survived_watermark = PromotedSpaceSizeOfObjects(); 1604 intptr_t survived_watermark = PromotedSpaceSizeOfObjects();
1607 1605
1608 scavenge_collector_->SelectScavengingVisitorsTable(); 1606 scavenge_collector_->SelectScavengingVisitorsTable();
1609 1607
(...skipping 4876 matching lines...) Expand 10 before | Expand all | Expand 10 after
6486 } 6484 }
6487 6485
6488 6486
6489 // static 6487 // static
6490 int Heap::GetStaticVisitorIdForMap(Map* map) { 6488 int Heap::GetStaticVisitorIdForMap(Map* map) {
6491 return StaticVisitorBase::GetVisitorId(map); 6489 return StaticVisitorBase::GetVisitorId(map);
6492 } 6490 }
6493 6491
6494 } // namespace internal 6492 } // namespace internal
6495 } // namespace v8 6493 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/heap/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698