move private test for sect_with_horizontal into unittests

tests/PathTest.cpp

Index: tests/PathTest.cpp
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index c76276080c959b2c49583f26d7526fa3f961d246..470fb8baf6b605d2f54d887602efd9286df87d17 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -97,6 +97,15 @@ static void make_path_crbug364224_simplified(SkPath* path) {
     path->close();
 }
 
+static void make_path_crbug638575(SkPath* path) {
+    // Test that sect_with_horizontal in SkLineClipper.cpp needs to pin after computing the
+    // intersection.
+    path->reset();
+    path->moveTo(-540000, -720000);
+    path->lineTo(-9.10000017e-05f, 9.99999996e-13f);
+    path->lineTo(1, 1);
+}

[mtklein, 2016/08/17 14:06:23]

We've dropped any sort of assert here... is this just tested by existing
SkASSERTs?

[reed1, 2016/08/17 14:15:02]

The line-clipper itself is loaded with the appropriate asserts already, just
needed to send in the right numbers to trigger them. This is the premiss for all
of the path-tests in this area of this file.

I'll add a comment to that effect.

+
 static void test_path_crbug364224() {
     SkPath path;
     SkPaint paint;
@@ -108,6 +117,9 @@ static void test_path_crbug364224() {
 
     make_path_crbug364224(&path);
     canvas->drawPath(path, paint);
+
+    make_path_crbug638575(&path);

[mtklein, 2016/08/17 14:06:23]

It doesn't look like this has anything to do with 364224.  Why don't we make it
independent?

static void test_crbug658575() {
    SkPath path;
    path.moveTo(...);
    path.lineTo(...);
    path.lineTo(...);
    // By not asserting in this function, we have tested that
sect_with_horizontal in SkLineClipper.cpp needs to pin after computing the
intersection.
}

[reed1, 2016/08/17 14:15:02]

True enough. That bug pointed this out, but really the CL now is just a
refactor. I'll rename the test appropriately.

+    canvas->drawPath(path, paint);
 }
 
 /**