move private test for sect_with_horizontal into unittests

tests/PathTest.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <cmath>
 #include "SkCanvas.h"
 #include "SkGeometry.h"
@@ skipping 79 matching lines @@
     path->lineTo(3.747501373f, 2.724499941f);
     path->close();
 }
 
 static void make_path_crbug364224_simplified(SkPath* path) {
     path->moveTo(3.747501373f, 2.724499941f);
     path->cubicTo(3.648251295f, 0.5194999576f, 3.575501442f, 0.4999999702f, 3.497501373f, 0.4999999702f);
     path->close();
 }
 
+static void make_path_crbug638575(SkPath* path) {
+    // Test that sect_with_horizontal in SkLineClipper.cpp needs to pin after computing the
+    // intersection.
+    path->reset();
+    path->moveTo(-540000, -720000);
+    path->lineTo(-9.10000017e-05f, 9.99999996e-13f);
+    path->lineTo(1, 1);
+}

[mtklein, 2016/08/17 14:06:23]

We've dropped any sort of assert here... is this just tested by existing
SkASSERTs?

[reed1, 2016/08/17 14:15:02]

The line-clipper itself is loaded with the appropriate asserts already, just
needed to send in the right numbers to trigger them. This is the premiss for all
of the path-tests in this area of this file.

I'll add a comment to that effect.

+
 static void test_path_crbug364224() {
     SkPath path;
     SkPaint paint;
     auto surface(SkSurface::MakeRasterN32Premul(84, 88));
     SkCanvas* canvas = surface->getCanvas();
 
     make_path_crbug364224_simplified(&path);
     canvas->drawPath(path, paint);
 
     make_path_crbug364224(&path);
     canvas->drawPath(path, paint);
+
+    make_path_crbug638575(&path);

[mtklein, 2016/08/17 14:06:23]

It doesn't look like this has anything to do with 364224.  Why don't we make it
independent?

static void test_crbug658575() {
    SkPath path;
    path.moveTo(...);
    path.lineTo(...);
    path.lineTo(...);
    // By not asserting in this function, we have tested that
sect_with_horizontal in SkLineClipper.cpp needs to pin after computing the
intersection.
}

[reed1, 2016/08/17 14:15:02]

True enough. That bug pointed this out, but really the CL now is just a
refactor. I'll rename the test appropriately.

+    canvas->drawPath(path, paint);
 }
 
 /**
  * In debug mode, this path was causing an assertion to fail in
  * SkPathStroker::preJoinTo() and, in Release, the use of an unitialized value.
  */
 static void make_path_crbugskia2820(SkPath* path, skiatest::Reporter* reporter) {
     SkPoint orig, p1, p2, p3;
     orig = SkPoint::Make(1.f, 1.f);
     p1 = SkPoint::Make(1.f - SK_ScalarNearlyZero, 1.f);
@@ skipping 4257 matching lines @@
     PathTest_Private::TestPathTo(reporter);
     PathRefTest_Private::TestPathRef(reporter);
     PathTest_Private::TestPathrefListeners(reporter);
     test_dump(reporter);
     test_path_crbug389050(reporter);
     test_path_crbugskia2820(reporter);
     test_skbug_3469(reporter);
     test_skbug_3239(reporter);
     test_bounds_crbug_513799(reporter);
 }