Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2250323002: Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test. (Closed)

Created:
4 years, 4 months ago by sivag
Modified:
4 years, 4 months ago
Reviewers:
Srirama, fs
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test. 1.Handle the test inside window.onload. 2.Change image src of same size. This triggers img.onload. 3.Check for no layout on src change. BUG=638288, 637859 Committed: https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23 Cr-Commit-Position: refs/heads/master@{#412501}

Patch Set 1 #

Patch Set 2 : Remove assert. #

Total comments: 2

Patch Set 3 : Test changed as per comments. #

Total comments: 4

Patch Set 4 : Add assert just after img src change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html View 1 2 3 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
sivag
@fs, srirama ptal.. This is failing on WebKit Mac10.11 (dbg) and WebKit Linux Debug. I ...
4 years, 4 months ago (2016-08-17 06:45:04 UTC) #4
Srirama
On 2016/08/17 06:45:04, sivag wrote: > @fs, srirama ptal.. > This is failing on WebKit ...
4 years, 4 months ago (2016-08-17 07:14:47 UTC) #6
Srirama
https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html File third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html (right): https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html#newcode14 third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14: img.onload = t.step_func(function() { use t.step_func_done and remove t.done ...
4 years, 4 months ago (2016-08-17 07:14:58 UTC) #7
sivag
https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html File third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html (right): https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html#newcode14 third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14: img.onload = t.step_func(function() { On 2016/08/17 07:14:57, Srirama wrote: ...
4 years, 4 months ago (2016-08-17 07:25:46 UTC) #8
sivag
On 2016/08/17 07:14:47, Srirama wrote: > On 2016/08/17 06:45:04, sivag wrote: > > @fs, srirama ...
4 years, 4 months ago (2016-08-17 07:27:15 UTC) #9
fs
https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html File third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html (right): https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html#newcode14 third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14: img.onload = t.step_func_done(function() { Does it still work/pass if ...
4 years, 4 months ago (2016-08-17 08:56:08 UTC) #10
sivag
https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html File third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html (right): https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html#newcode14 third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14: img.onload = t.step_func_done(function() { On 2016/08/17 08:56:08, fs wrote: ...
4 years, 4 months ago (2016-08-17 09:00:09 UTC) #11
fs
https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html File third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html (right): https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html#newcode14 third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14: img.onload = t.step_func_done(function() { On 2016/08/17 at 09:00:09, sivag ...
4 years, 4 months ago (2016-08-17 10:27:47 UTC) #12
sivag
ptal.. https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html File third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html (right): https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html#newcode14 third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14: img.onload = t.step_func_done(function() { On 2016/08/17 10:27:46, fs ...
4 years, 4 months ago (2016-08-17 10:41:09 UTC) #13
fs
lgtm
4 years, 4 months ago (2016-08-17 10:43:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250323002/60001
4 years, 4 months ago (2016-08-17 10:44:40 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-17 11:54:18 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 11:56:12 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23
Cr-Commit-Position: refs/heads/master@{#412501}

Powered by Google App Engine
This is Rietveld 408576698