Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test.

Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
Committed: https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23
Cr-Commit-Position: refs/heads/master@{#412501}

[sivag, 2016-08-17 06:27:11]

Description was changed from

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle window.onload. Layout count should be greater than zero.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
==========

to

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle window.onload. Layout count should be greater than zero.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
==========

[sivag, 2016-08-17 06:27:11]

siva.gunturi@samsung.com changed reviewers:
+ srirama.m@samsung.com

[sivag, 2016-08-17 06:40:58]

siva.gunturi@samsung.com changed reviewers:
+ fs@opera.com

[sivag, 2016-08-17 06:45:04]

@fs, srirama ptal..
This is failing on WebKit Mac10.11 (dbg) and WebKit Linux Debug. I cant find
these builds in trybots. Where can we trigger them?

[sivag, 2016-08-17 07:01:43]

Description was changed from

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle window.onload. Layout count should be greater than zero.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
==========

to

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
==========

[Srirama, 2016-08-17 07:14:47]

On 2016/08/17 06:45:04, sivag wrote:
> @fs, srirama ptal..
> This is failing on WebKit Mac10.11 (dbg) and WebKit Linux Debug. I cant find
> these builds in trybots. Where can we trigger them?

I think we cannot trigger those from here, but we have to check the status here
https://build.chromium.org/p/chromium.webkit/builders/ after landing the patch.
As it is flaky in linux, may be you can try running it 1000 times locally and
see if it is still flaky.

[Srirama, 2016-08-17 07:14:58]

https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html
(right):

https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14:
img.onload = t.step_func(function() {
use t.step_func_done and remove t.done below.

[sivag, 2016-08-17 07:25:46]

https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html
(right):

https://codereview.chromium.org/2250323002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14:
img.onload = t.step_func(function() {
On 2016/08/17 07:14:57, Srirama wrote:
> use t.step_func_done and remove t.done below.

Done.

[sivag, 2016-08-17 07:27:15]

On 2016/08/17 07:14:47, Srirama wrote:
> On 2016/08/17 06:45:04, sivag wrote:
> > @fs, srirama ptal..
> > This is failing on WebKit Mac10.11 (dbg) and WebKit Linux Debug. I cant find
> > these builds in trybots. Where can we trigger them?
> 
> I think we cannot trigger those from here, but we have to check the status
here
> https://build.chromium.org/p/chromium.webkit/builders/ after landing the
patch.
> As it is flaky in linux, may be you can try running it 1000 times locally and
> see if it is still flaky.

The old test is failing in my linux machine when i iterate it 1000 times.
This patch fixes the issue.

[fs, 2016-08-17 08:56:08]

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html
(right):

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14:
img.onload = t.step_func_done(function() {
Does it still work/pass if you assert needsLayoutCount == 0 here just after
setting .src?

[sivag, 2016-08-17 09:00:09]

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html
(right):

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14:
img.onload = t.step_func_done(function() {
On 2016/08/17 08:56:08, fs wrote:
> Does it still work/pass if you assert needsLayoutCount == 0 here just after
> setting .src?

yes it works fine.

[fs, 2016-08-17 10:27:47]

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html
(right):

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14:
img.onload = t.step_func_done(function() {
On 2016/08/17 at 09:00:09, sivag wrote:
> On 2016/08/17 08:56:08, fs wrote:
> > Does it still work/pass if you assert needsLayoutCount == 0 here just after
> > setting .src?
> 
> yes it works fine.

Could you add that assertion too then? =)

[sivag, 2016-08-17 10:41:09]

ptal..

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html
(right):

https://codereview.chromium.org/2250323002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html:14:
img.onload = t.step_func_done(function() {
On 2016/08/17 10:27:46, fs wrote:
> On 2016/08/17 at 09:00:09, sivag wrote:
> > On 2016/08/17 08:56:08, fs wrote:
> > > Does it still work/pass if you assert needsLayoutCount == 0 here just
after
> > > setting .src?
> > 
> > yes it works fine.
> 
> Could you add that assertion too then? =)

Done.

[fs, 2016-08-17 10:43:04]

lgtm

[sivag, 2016-08-17 10:44:25]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2016-08-17 10:44:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 11:54:17]

Description was changed from

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
==========

to

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
==========

[commit-bot: I haz the power, 2016-08-17 11:54:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-17 11:56:11]

Description was changed from

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859
==========

to

==========
Handle window.onload and img.onload in
image-change-without-resize-shouldnt-layout test.

1.Handle the test inside window.onload.
2.Change image src of same size. This triggers img.onload.
3.Check for no layout on src change.

BUG=638288, 637859

Committed: https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23
Cr-Commit-Position: refs/heads/master@{#412501}
==========

[commit-bot: I haz the power, 2016-08-17 11:56:12]

Patchset 4 (id:??) landed as
https://crrev.com/f6ceacf5494a9fff8d53c86d6a39f19f954c8e23
Cr-Commit-Position: refs/heads/master@{#412501}