third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html - Issue 2250323002: Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/image-change-without-resize-shouldnt-layout.html

Issue 2250323002: Handle window.onload and img.onload in image-change-without-resize-shouldnt-layout test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test changed as per comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>This test ensures that when an image changes, but doesn't change size (li ke in an Animated GIF), we don't force a Layout.</title>	2 <title>This test ensures that when an image changes, but doesn't change size (li ke in an Animated GIF), we don't force a Layout.</title>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <div style="float: left;">	5 <div style="float: left;">

6 <img style="max-width: 100%" src="../replaced/resources/1x1-blue.png">	6 <img style="max-width: 100%" src="../replaced/resources/1x1-blue.png">

7 </div>	7 </div>

8 <script>	8 <script>

9 //TODO(siva.gunturi): Use async_test and use asserts on image.onload and window. onload.	9 async_test(function(t) {

10 test(function() {	10 window.onload = t.step_func(function() {

11 document.documentElement.offsetTop;	11 document.documentElement.offsetTop;

12 var img = document.querySelector("img");	12 var img = document.querySelector("img");

13 img.src = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAMAAAAoyzS 7AAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAAGUEx URf8AAAAAAEGjEgMAAAAMSURBVHjaYmAACDAAAAIAAU9tWeEAAAAASUVORK5CYII=";	13 img.src = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAMAAAA oyzS7AAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAA GUExURf8AAAAAAEGjEgMAAAAMSURBVHjaYmAACDAAAAIAAU9tWeEAAAAASUVORK5CYII=";

14 assert_equals(internals.needsLayoutCount(), 0);	14 img.onload = t.step_func_done(function() {
	fs 2016/08/17 08:56:08 Does it still work/pass if you assert needsLayoutC Does it still work/pass if you assert needsLayoutCount == 0 here just after setting .src? sivag 2016/08/17 09:00:09 yes it works fine. Show quoted text On 2016/08/17 08:56:08, fs wrote: > Does it still work/pass if you assert needsLayoutCount == 0 here just after > setting .src? yes it works fine. fs 2016/08/17 10:27:46 Could you add that assertion too then? =) Show quoted text On 2016/08/17 at 09:00:09, sivag wrote: > On 2016/08/17 08:56:08, fs wrote: > > Does it still work/pass if you assert needsLayoutCount == 0 here just after > > setting .src? > > yes it works fine. Could you add that assertion too then? =) sivag 2016/08/17 10:41:09 Done. Show quoted text On 2016/08/17 10:27:46, fs wrote: > On 2016/08/17 at 09:00:09, sivag wrote: > > On 2016/08/17 08:56:08, fs wrote: > > > Does it still work/pass if you assert needsLayoutCount == 0 here just after > > > setting .src? > > > > yes it works fine. > > Could you add that assertion too then? =) Done.
	15 assert_equals(internals.needsLayoutCount(), 0);

	16 });

	17 });

15 });	18 });

16 </script>	19 </script>

OLD	NEW

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »