Fix ASAN canary crashes.

Fix ASAN canary crashes.

The ASAN startup code now uses an exported function GetUploadsEnabled from chrome_elf to determine
whether uploads are enabled. Additionally we don't link with crashpad/app in chrome.exe. chrome.exe
now links with the new library target crashpad/run_as_crashpad_handler. The ASAN kasko code today
gets exported crash functions from the exe, which won't work correctly due to crashpad having moved
to chrome_elf.dll. This needs to be fixed for ASAN crashes to be reported correctly.

BUG=638370, 604923
Committed: https://crrev.com/4bb92a6392a2f8bdc5c6c1319690800748870f1c
Cr-Commit-Position: refs/heads/master@{#412405}

[ananta, 2016-08-16 22:59:21]

ananta@chromium.org changed reviewers:
+ scottmg@chromium.org

[ananta, 2016-08-16 22:59:31]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 22:59:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-08-16 23:00:18]

(wrote together, over the shoulder lgtm)

[ananta, 2016-08-16 23:00:53]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2016-08-16 23:00:54]

+sky for chrome owners stamp

[ananta, 2016-08-16 23:02:00]

Description was changed from

==========
Fix ASAN canary crashes.

The ASAN startup code now uses an exported function GetUploadsEnabled from
chrome_elf to determine
whether uploads are enabled. Additionally we don't link with crashpad/app in
chrome.exe. chrome.exe
now links with the new library target crashpad/run_as_crashpad_handler. The ASAN
kasko code today
gets exported crash functions from the exe, which won't work correctly due to
crashpad having moved
to chrome_elf.dll. This needs to be fixed for ASAN crashes to be reported
correctly.

BUG=638370
==========

to

==========
Fix ASAN canary crashes.

The ASAN startup code now uses an exported function GetUploadsEnabled from
chrome_elf to determine
whether uploads are enabled. Additionally we don't link with crashpad/app in
chrome.exe. chrome.exe
now links with the new library target crashpad/run_as_crashpad_handler. The ASAN
kasko code today
gets exported crash functions from the exe, which won't work correctly due to
crashpad having moved
to chrome_elf.dll. This needs to be fixed for ASAN crashes to be reported
correctly.

BUG=638370, 604923
==========

[sky, 2016-08-16 23:11:14]

Can you include in this patch update OWNERS to add yourself (and probably
scottmg as well) to the .cc files you are changing here?

[ananta, 2016-08-16 23:27:23]

On 2016/08/16 23:11:14, sky wrote:
> Can you include in this patch update OWNERS to add yourself (and probably
> scottmg as well) to the .cc files you are changing here?

Added us for chrome/app/main_dll_loader_win.cc and
chrome_crash_reporter_client_win.cc

[ananta, 2016-08-16 23:27:40]

ananta@chromium.org changed reviewers:
+ robertshield@chromium.org

[ananta, 2016-08-16 23:28:03]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-16 23:42:17]

LGTM

[commit-bot: I haz the power, 2016-08-17 00:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:19:09]

Dry run: This issue passed the CQ dry run.

[robertshield, 2016-08-17 00:30:02]

lgtm

[ananta, 2016-08-17 00:57:41]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-08-17 00:57:42]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2250263002/#ps20001
(title: "Add ananta and scottmg to owners for main_loader_dll_win.cc and
chrome_crash_reporter_client_win.cc")

[commit-bot: I haz the power, 2016-08-17 00:58:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 01:03:24]

Description was changed from

==========
Fix ASAN canary crashes.

The ASAN startup code now uses an exported function GetUploadsEnabled from
chrome_elf to determine
whether uploads are enabled. Additionally we don't link with crashpad/app in
chrome.exe. chrome.exe
now links with the new library target crashpad/run_as_crashpad_handler. The ASAN
kasko code today
gets exported crash functions from the exe, which won't work correctly due to
crashpad having moved
to chrome_elf.dll. This needs to be fixed for ASAN crashes to be reported
correctly.

BUG=638370, 604923
==========

to

==========
Fix ASAN canary crashes.

The ASAN startup code now uses an exported function GetUploadsEnabled from
chrome_elf to determine
whether uploads are enabled. Additionally we don't link with crashpad/app in
chrome.exe. chrome.exe
now links with the new library target crashpad/run_as_crashpad_handler. The ASAN
kasko code today
gets exported crash functions from the exe, which won't work correctly due to
crashpad having moved
to chrome_elf.dll. This needs to be fixed for ASAN crashes to be reported
correctly.

BUG=638370, 604923
==========

[commit-bot: I haz the power, 2016-08-17 01:03:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 01:04:59]

Description was changed from

==========
Fix ASAN canary crashes.

The ASAN startup code now uses an exported function GetUploadsEnabled from
chrome_elf to determine
whether uploads are enabled. Additionally we don't link with crashpad/app in
chrome.exe. chrome.exe
now links with the new library target crashpad/run_as_crashpad_handler. The ASAN
kasko code today
gets exported crash functions from the exe, which won't work correctly due to
crashpad having moved
to chrome_elf.dll. This needs to be fixed for ASAN crashes to be reported
correctly.

BUG=638370, 604923
==========

to

==========
Fix ASAN canary crashes.

The ASAN startup code now uses an exported function GetUploadsEnabled from
chrome_elf to determine
whether uploads are enabled. Additionally we don't link with crashpad/app in
chrome.exe. chrome.exe
now links with the new library target crashpad/run_as_crashpad_handler. The ASAN
kasko code today
gets exported crash functions from the exe, which won't work correctly due to
crashpad having moved
to chrome_elf.dll. This needs to be fixed for ASAN crashes to be reported
correctly.

BUG=638370, 604923

Committed: https://crrev.com/4bb92a6392a2f8bdc5c6c1319690800748870f1c
Cr-Commit-Position: refs/heads/master@{#412405}
==========

[commit-bot: I haz the power, 2016-08-17 01:05:00]

Patchset 2 (id:??) landed as
https://crrev.com/4bb92a6392a2f8bdc5c6c1319690800748870f1c
Cr-Commit-Position: refs/heads/master@{#412405}