chrome/BUILD.gn - Issue 2250263002: Fix ASAN canary crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 2250263002: Fix ASAN canary crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ananta and scottmg to owners for main_loader_dll_win.cc and chrome_crash_reporter_client_win.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 55aa4670861d82c359e58ceb5d7458a8a16299c1..ec5894a95050ef687dd908f8cad511ac506bc6bc 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -134,8 +134,6 @@ if (!is_android && !is_mac) {

if (is_win) {

sources += [

- "app/chrome_crash_reporter_client_win.cc",

- "app/chrome_crash_reporter_client_win.h",

"app/chrome_exe.rc",

"app/chrome_exe_load_config_win.cc",

"app/chrome_exe_main_win.cc",

@@ -170,8 +168,7 @@ if (!is_android && !is_mac) {

"//chrome/installer/util:with_no_strings",

"//chrome_elf",

"//components/browser_watcher:browser_watcher_client",

- "//components/crash/content/app",

- "//components/crash/core/common",

+ "//components/crash/content/app:run_as_crashpad_handler",

"//components/flags_ui:switches",

"//components/startup_metric_utils/common",

"//content:sandbox_helper_win",

« no previous file with comments | « no previous file | chrome/app/OWNERS » ('j') | no next file with comments »