[SubZero] Added InstMIPS32Load to differentiate stores from loads

[SubZero]Added InstMIPS32Load to differentiate stores from loads

Both the operands in InstMIPS32Memory are source. However in load instructions, first operand is a destination. The InstMIPS32Load treats first operand as destination and second operand as source.

R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b1a0fb1321676ca5f4a8386f51bb121b86e53a27

[jaydeep.patil, 2016-08-18 12:00:19]

Description was changed from

==========
Added InstMIPS32Load to differentiate stores from loads

BUG=
==========

to

==========
[SubZero]Added InstMIPS32Load to differentiate stores from loads

Both the operands in InstMIPS32Memory are source. However in load instructions,
first operand is a destination. The InstMIPS32Load treats first operand as
destination and second operand as source.
==========

[jaydeep.patil, 2016-08-18 12:00:19]

jaydeep.patil@imgtec.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com,
mohit.bhakkad@imgtec.com, srdjan.obucina@imgtec.com, stichnot@chromium.org

[John, 2016-08-18 14:53:36]

lgtm

https://codereview.chromium.org/2250203005/diff/1/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/2250203005/diff/1/src/IceInstMIPS32.h#newcode555
src/IceInstMIPS32.h:555: class InstMIPS32Memory : public InstMIPS32 {
Rename this to InstMIPS32Store?

[Jim Stichnoth, 2016-08-18 15:08:56]

https://codereview.chromium.org/2250203005/diff/1/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/2250203005/diff/1/src/IceInstMIPS32.h#newcode552
src/IceInstMIPS32.h:552: // InstMIPS32Memory represents instructions which
stores data to memory
What do you think about renaming this to InstMIPS32Store, for
consistency/clarity?

[jaydeep.patil, 2016-08-19 04:29:11]

Addressed review comments.

[Jim Stichnoth, 2016-08-19 05:36:26]

lgtm

[Jim Stichnoth, 2016-08-19 05:37:34]

Description was changed from

==========
[SubZero]Added InstMIPS32Load to differentiate stores from loads

Both the operands in InstMIPS32Memory are source. However in load instructions,
first operand is a destination. The InstMIPS32Load treats first operand as
destination and second operand as source.
==========

to

==========
[SubZero]Added InstMIPS32Load to differentiate stores from loads

Both the operands in InstMIPS32Memory are source. However in load instructions,
first operand is a destination. The InstMIPS32Load treats first operand as
destination and second operand as source.

R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-08-19 05:37:36]

Committed patchset #2 (id:20001) manually as
b1a0fb1321676ca5f4a8386f51bb121b86e53a27 (presubmit successful).