New Public IdFromWebContents method on TabManager.

chrome/browser/extensions/api/tabs/tabs_test.cc

Index: chrome/browser/extensions/api/tabs/tabs_test.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc
index 6927d6f7b4b71a887347a91a4b8dc18191f60d5e..e6355a5b82851f0b7efcda8bd718340e1dd7666c 100644
--- a/chrome/browser/extensions/api/tabs/tabs_test.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_test.cc
@@ -1360,8 +1360,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DiscardedProperty) {
   EXPECT_FALSE(tab_object_a->discarded);
 
   // Discards one tab.
-  EXPECT_TRUE(
-      tab_manager->DiscardTabById(reinterpret_cast<int64_t>(web_contents_a)));
+  EXPECT_TRUE(tab_manager->DiscardTabById(
+      memory::TabManager::IdFromWebContents(web_contents_a)));

[Devlin, 2016/08/16 22:56:06]

We could make this even easier by providing a
DiscardTab[WithWebContents](content::WebContents*) method in TabManager, so that
callers don't even need to go through this effort.  WDYT?

[Anderson Silva, 2016/08/16 23:13:31]

Done. You're right, I've even already implemented such function.

   web_contents_a = tab_strip_model->GetWebContentsAt(1);
 
   // Make sure the property is changed accordingly after discarding the tab.
@@ -1394,8 +1394,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DiscardedProperty) {
   }
 
   // Discards another created tab.
-  EXPECT_TRUE(
-      tab_manager->DiscardTabById(reinterpret_cast<int64_t>(web_contents_b)));
+  EXPECT_TRUE(tab_manager->DiscardTabById(
+      memory::TabManager::IdFromWebContents(web_contents_b)));
 
   // Get non-discarded tabs after discarding two created tabs.
   {