New Public IdFromWebContents method on TabManager.

chrome/browser/extensions/api/tabs/tabs_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <string>
@@ skipping 1342 matching lines @@
   }
 
   TabStripModel* tab_strip_model = browser()->tab_strip_model();
 
   // Creates Tab object to ensure the property is correct for the extension.
   std::unique_ptr<api::tabs::Tab> tab_object_a =
       ExtensionTabUtil::CreateTabObject(web_contents_a, tab_strip_model, 0);
   EXPECT_FALSE(tab_object_a->discarded);
 
   // Discards one tab.
-  EXPECT_TRUE(
-      tab_manager->DiscardTabById(reinterpret_cast<int64_t>(web_contents_a)));
+  EXPECT_TRUE(tab_manager->DiscardTabById(
+      memory::TabManager::IdFromWebContents(web_contents_a)));

[Devlin, 2016/08/16 22:56:06]

We could make this even easier by providing a
DiscardTab[WithWebContents](content::WebContents*) method in TabManager, so that
callers don't even need to go through this effort.  WDYT?

[Anderson Silva, 2016/08/16 23:13:31]

Done. You're right, I've even already implemented such function.

   web_contents_a = tab_strip_model->GetWebContentsAt(1);
 
   // Make sure the property is changed accordingly after discarding the tab.
   tab_object_a =
       ExtensionTabUtil::CreateTabObject(web_contents_a, tab_strip_model, 0);
   EXPECT_TRUE(tab_object_a->discarded);
 
   // Get non-discarded tabs after discarding one tab.
   {
     std::unique_ptr<base::ListValue> result(
@@ skipping 12 matching lines @@
 
     int id = -1;
     base::Value* tab = nullptr;
     EXPECT_TRUE(result->Get(0, &tab));
     utils::ToDictionary(tab)->GetInteger(keys::kIdKey, &id);
 
     EXPECT_EQ(tab_id_a, id);
   }
 
   // Discards another created tab.
-  EXPECT_TRUE(
-      tab_manager->DiscardTabById(reinterpret_cast<int64_t>(web_contents_b)));
+  EXPECT_TRUE(tab_manager->DiscardTabById(
+      memory::TabManager::IdFromWebContents(web_contents_b)));
 
   // Get non-discarded tabs after discarding two created tabs.
   {
     std::unique_ptr<base::ListValue> result(
         RunQueryFunction("[{\"discarded\": false}]"));
     EXPECT_EQ(1u, result->GetSize());
 
     // Make sure the returned tab is the correct one.
     int tab_id_c =
         ExtensionTabUtil::GetTabId(tab_strip_model->GetWebContentsAt(0));
@@ skipping 705 matching lines @@
   EXPECT_TRUE(
       base::MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
 
   // chrome.tabs.setZoomSettings().
   error = RunSetZoomSettingsExpectError(tab_id, "manual", "per-tab");
   EXPECT_TRUE(
       base::MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
 }
 
 }  // namespace extensions