Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2250123003: [BotHealth] Disable PCv2 on reference using ShouldDisable (Closed)

Created:
4 years, 4 months ago by eakuefner
Modified:
4 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BotHealth] Disable PCv2 on reference using ShouldDisable As of crrev.com/2249623002, super-/subclass decorator usages no longer affect sub-/superclasses respectively. PCv2 is currently intended to be disabled on all reference builds until the ref build is rolled, and this had previously been done using the @Disabled decorator on the superclass. This CL ports that functionality into PCv2's ShouldDisable method. BUG=619254 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/fc7e75b896b8b0905a295300d9482af562e023e9 Cr-Commit-Position: refs/heads/master@{#412400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/benchmarks/page_cycler_v2.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
eakuefner
PTAL. I have tested locally to ensure that this solution works.
4 years, 4 months ago (2016-08-16 17:33:47 UTC) #3
aiolos (Not reviewing)
lgtm
4 years, 4 months ago (2016-08-16 17:35:04 UTC) #4
nednguyen
lgtm
4 years, 4 months ago (2016-08-16 17:35:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250123003/1
4 years, 4 months ago (2016-08-16 17:36:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-16 21:34:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250123003/1
4 years, 4 months ago (2016-08-16 23:09:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 00:41:35 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 00:44:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc7e75b896b8b0905a295300d9482af562e023e9
Cr-Commit-Position: refs/heads/master@{#412400}

Powered by Google App Engine
This is Rietveld 408576698