Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2250123003: [BotHealth] Disable PCv2 on reference using ShouldDisable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """The page cycler v2. 5 """The page cycler v2.
6 6
7 For details, see design doc: 7 For details, see design doc:
8 https://docs.google.com/document/d/1EZQX-x3eEphXupiX-Hq7T4Afju5_sIdxPWYetj7ynd0 8 https://docs.google.com/document/d/1EZQX-x3eEphXupiX-Hq7T4Afju5_sIdxPWYetj7ynd0
9 """ 9 """
10 10
11 from core import perf_benchmark 11 from core import perf_benchmark
12 import page_sets 12 import page_sets
13 13
14 from telemetry import benchmark 14 from telemetry import benchmark
15 from telemetry.page import cache_temperature 15 from telemetry.page import cache_temperature
16 from telemetry.timeline import chrome_trace_category_filter 16 from telemetry.timeline import chrome_trace_category_filter
17 from telemetry.web_perf import timeline_based_measurement 17 from telemetry.web_perf import timeline_based_measurement
18 18
19 19
20 # crbug.com/619254
21 @benchmark.Disabled('reference')
22 class _PageCyclerV2(perf_benchmark.PerfBenchmark): 20 class _PageCyclerV2(perf_benchmark.PerfBenchmark):
23 options = {'pageset_repeat': 2} 21 options = {'pageset_repeat': 2}
24 22
25 def CreateTimelineBasedMeasurementOptions(self): 23 def CreateTimelineBasedMeasurementOptions(self):
26 cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter( 24 cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
27 filter_string='blink.console,navigation,blink.user_timing,loading') 25 filter_string='blink.console,navigation,blink.user_timing,loading')
28 26
29 # Below categories are needed for first-meaningful-paint computation. 27 # Below categories are needed for first-meaningful-paint computation.
30 cat_filter.AddDisabledByDefault('disabled-by-default-blink.debug.layout') 28 cat_filter.AddDisabledByDefault('disabled-by-default-blink.debug.layout')
31 cat_filter.AddIncludedCategory('devtools.timeline') 29 cat_filter.AddIncludedCategory('devtools.timeline')
32 30
33 tbm_options = timeline_based_measurement.Options( 31 tbm_options = timeline_based_measurement.Options(
34 overhead_level=cat_filter) 32 overhead_level=cat_filter)
35 tbm_options.SetTimelineBasedMetrics(['loadingMetric']) 33 tbm_options.SetTimelineBasedMetrics(['loadingMetric'])
36 return tbm_options 34 return tbm_options
37 35
38 @classmethod 36 @classmethod
39 def ShouldDisable(cls, possible_browser): 37 def ShouldDisable(cls, possible_browser):
38 # crbug.com/619254
39 if possible_browser.browser_type == 'reference':
40 return True
41
40 # crbug.com/616781 42 # crbug.com/616781
41 if (cls.IsSvelte(possible_browser) or 43 if (cls.IsSvelte(possible_browser) or
42 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or 44 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
43 possible_browser.platform.GetDeviceTypeName() == 'AOSP on BullHead'): 45 possible_browser.platform.GetDeviceTypeName() == 'AOSP on BullHead'):
44 return True 46 return True
45 return False 47 return False
46 48
47 49
48 class PageCyclerV2Typical25(_PageCyclerV2): 50 class PageCyclerV2Typical25(_PageCyclerV2):
49 """Page load time benchmark for a 25 typical web pages. 51 """Page load time benchmark for a 25 typical web pages.
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 set, without running in out-of-process iframes mode.. """ 197 set, without running in out-of-process iframes mode.. """
196 page_set = page_sets.OopifBasicPageSet 198 page_set = page_sets.OopifBasicPageSet
197 199
198 @classmethod 200 @classmethod
199 def Name(cls): 201 def Name(cls):
200 return 'page_cycler_v2.basic_oopif' 202 return 'page_cycler_v2.basic_oopif'
201 203
202 def CreateStorySet(self, options): 204 def CreateStorySet(self, options):
203 return page_sets.OopifBasicPageSet(cache_temperatures=[ 205 return page_sets.OopifBasicPageSet(cache_temperatures=[
204 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM]) 206 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698