Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2250113003: Revert of [Android] Remove some dead code in CompositorViewHolder (Closed)

Created:
4 years, 4 months ago by Michael van Ouwerkerk
Modified:
4 years, 4 months ago
Reviewers:
Ian Wen, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Remove some dead code in CompositorViewHolder (patchset #1 id:1 of https://codereview.chromium.org/2248793003/ ) Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=638535 This crashes due to: 08-17 10:49:47.072 15523 15523 W System.err: java.lang.ClassCastException: android.widget.FrameLayout$LayoutParams cannot be cast to android.support.design.widget.CoordinatorLayout$LayoutParams 08-17 10:49:47.073 15523 15523 W System.err: at org.chromium.chrome.browser.compositor.CompositorViewHolder.updateContentOverlayVisibility(CompositorViewHolder.java:808) Original issue's description: > [Android] Remove some dead code in CompositorViewHolder > > After https://codereview.chromium.org/2241643003, Tab#getView() will > only return the wrapper framelyout that wraps infobars, content view or > native page view. This work simplifies the logic in > CompositorViewHolder. > > BUG=635871 > > Committed: https://crrev.com/01dca5c74d54e47c725ae94d7714884bf51f21af > Cr-Commit-Position: refs/heads/master@{#412133} TBR=dfalcantara@chromium.org,ianwen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635871 Committed: https://crrev.com/6fe70b4ceaf63a3240c747f6da1a2633d7935d72 Cr-Commit-Position: refs/heads/master@{#412489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 3 chunks +14 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael van Ouwerkerk
Created Revert of [Android] Remove some dead code in CompositorViewHolder
4 years, 4 months ago (2016-08-17 09:58:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250113003/1
4 years, 4 months ago (2016-08-17 09:58:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 10:33:10 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 10:34:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fe70b4ceaf63a3240c747f6da1a2633d7935d72
Cr-Commit-Position: refs/heads/master@{#412489}

Powered by Google App Engine
This is Rietveld 408576698