DescriptionRevert of [Android] Remove some dead code in CompositorViewHolder (patchset #1 id:1 of https://codereview.chromium.org/2248793003/ )
Reason for revert:
See https://bugs.chromium.org/p/chromium/issues/detail?id=638535
This crashes due to:
08-17 10:49:47.072 15523 15523 W System.err: java.lang.ClassCastException: android.widget.FrameLayout$LayoutParams cannot be cast to android.support.design.widget.CoordinatorLayout$LayoutParams
08-17 10:49:47.073 15523 15523 W System.err: at org.chromium.chrome.browser.compositor.CompositorViewHolder.updateContentOverlayVisibility(CompositorViewHolder.java:808)
Original issue's description:
> [Android] Remove some dead code in CompositorViewHolder
>
> After https://codereview.chromium.org/2241643003, Tab#getView() will
> only return the wrapper framelyout that wraps infobars, content view or
> native page view. This work simplifies the logic in
> CompositorViewHolder.
>
> BUG=635871
>
> Committed: https://crrev.com/01dca5c74d54e47c725ae94d7714884bf51f21af
> Cr-Commit-Position: refs/heads/master@{#412133}
TBR=dfalcantara@chromium.org,ianwen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635871
Committed: https://crrev.com/6fe70b4ceaf63a3240c747f6da1a2633d7935d72
Cr-Commit-Position: refs/heads/master@{#412489}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|