chrome/browser/geolocation/geolocation_infobar_delegate_android.h - Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_infobar_delegate_android.h

Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobar-remember-decision

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/geolocation/geolocation_infobar_delegate_android.cc » ('j') | chrome/browser/permissions/permission_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_infobar_delegate_android.h

diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate_android.h b/chrome/browser/geolocation/geolocation_infobar_delegate_android.h

index a87e84da48fff3cad556d03f9060f1bb473f4873..90dfffb2228dddb9465a12265a4ac6c3d5aa5584 100644

--- a/chrome/browser/geolocation/geolocation_infobar_delegate_android.h

+++ b/chrome/browser/geolocation/geolocation_infobar_delegate_android.h

@@ -15,7 +15,7 @@ class InfoBarService;

// GeolocationInfoBarDelegateAndroids are created by the

// PermissionQueueController to control the display

// and handling of geolocation permission infobars to the user.

-class GeolocationInfoBarDelegateAndroid : public PermissionInfobarDelegate {

+class GeolocationInfoBarDelegateAndroid : public PermissionInfoBarDelegate {

public:

// Creates a geolocation infobar and delegate and adds the infobar to

// |infobar_service|. Returns the infobar if it was successfully added.

@@ -37,8 +37,6 @@ class GeolocationInfoBarDelegateAndroid : public PermissionInfobarDelegate {

int GetIconId() const override;

int GetMessageResourceId() const override;

- GURL requesting_frame_;

DISALLOW_COPY_AND_ASSIGN(GeolocationInfoBarDelegateAndroid);

};