chrome/browser/geolocation/geolocation_infobar_delegate_android.cc - Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobar-remember-decision

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_infobar_delegate_android.h ('k') | chrome/browser/media/midi_permission_infobar_delegate_android.h » ('j') | chrome/browser/permissions/permission_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc b/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

index 33a4917f0cfed0c812882749286caa6f0ed6fa40..e6501647e5de4e36840a274f260a09fb31169c01 100644

--- a/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

+++ b/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

@@ -18,7 +18,7 @@ infobars::InfoBar* GeolocationInfoBarDelegateAndroid::Create(

Profile* profile,

const PermissionSetCallback& callback) {

return infobar_service->AddInfoBar(

- CreatePermissionInfoBar(std::unique_ptr<PermissionInfobarDelegate>(

+ CreatePermissionInfoBar(std::unique_ptr<PermissionInfoBarDelegate>(

new GeolocationInfoBarDelegateAndroid(requesting_frame, user_gesture,

profile, callback))));

}

@@ -28,13 +28,12 @@ GeolocationInfoBarDelegateAndroid::GeolocationInfoBarDelegateAndroid(

bool user_gesture,

Profile* profile,

const PermissionSetCallback& callback)

- : PermissionInfobarDelegate(requesting_frame,

+ : PermissionInfoBarDelegate(requesting_frame,

content::PermissionType::GEOLOCATION,

CONTENT_SETTINGS_TYPE_GEOLOCATION,

user_gesture,

profile,

- callback),

- requesting_frame_(requesting_frame) {}

+ callback) {}

GeolocationInfoBarDelegateAndroid::~GeolocationInfoBarDelegateAndroid() {}