src/gpu/batches/GrAnalyticRectBatch.cpp - Issue 2249973003: Add alternative ambient shadow method to Android shadow sample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/batches/GrAnalyticRectBatch.cpp

Issue 2249973003: Add alternative ambient shadow method to Android shadow sample (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Nits (again) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/batches/GrAnalyticRectBatch.cpp

diff --git a/src/gpu/batches/GrAnalyticRectBatch.cpp b/src/gpu/batches/GrAnalyticRectBatch.cpp

index b41aa7f71940e841a3a4c6aa891de41bb901d2bb..b13ea77a6604c7ed35da17866bb7388094165bfa 100644

--- a/src/gpu/batches/GrAnalyticRectBatch.cpp

+++ b/src/gpu/batches/GrAnalyticRectBatch.cpp

@@ -183,7 +183,7 @@ public:

fragBuilder->codeAppend( "}");

fragBuilder->codeAppend( "float dvSign = sign(dot(offset, dvAxis));");

- fragBuilder->codeAppendf("%s = vec3(dvSign * dvAxis, dvLength);",

+ fragBuilder->codeAppendf("%s = vec4(dvSign * dvAxis, dvLength, 0.0);",

args.fDistanceVectorName);

}

« no previous file with comments | « src/gpu/GrOvalRenderer.cpp ('k') | src/gpu/glsl/GrGLSLProgramBuilder.cpp » ('j') | no next file with comments »