components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc - Issue 2249903003: 📰 Empty state handling for the Bookmarks section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2249903003: 📰 Empty state handling for the Bookmarks section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix instrumentation test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

index 04395e5c570d511e5f7abd467f852a0437dedffc..85622fa8f5e0e8012d56f658829d66ba1f840054 100644

--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

@@ -104,7 +104,9 @@ CategoryStatus BookmarkSuggestionsProvider::GetCategoryStatus(

CategoryInfo BookmarkSuggestionsProvider::GetCategoryInfo(Category category) {

return CategoryInfo(

l10n_util::GetStringUTF16(IDS_NTP_BOOKMARK_SUGGESTIONS_SECTION_HEADER),

- ContentSuggestionsCardLayout::MINIMAL_CARD, /* has_more_button */ true);

+ ContentSuggestionsCardLayout::MINIMAL_CARD,

+ /* has_more_button */ true,

+ /* show_if_empty */ false);

}

void BookmarkSuggestionsProvider::DismissSuggestion(