chrome/browser/android/ntp/ntp_snippets_bridge.cc - Issue 2249903003: 📰 Empty state handling for the Bookmarks section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2249903003: 📰 Empty state handling for the Bookmarks section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix instrumentation test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

index e4e6aae1abde2f1cb272d32dd12be96c08eab9c8..b003ace9cb061166a15fc789096230e7f410c1fa 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

@@ -141,7 +141,8 @@ base::android::ScopedJavaLocalRef<jobject> NTPSnippetsBridge::GetCategoryInfo(

return base::android::ScopedJavaLocalRef<jobject>(env, nullptr);

return Java_SnippetsBridge_createSuggestionsCategoryInfo(

env, ConvertUTF16ToJavaString(env, info->title()),

- static_cast<int>(info->card_layout()), info->has_more_button());

+ static_cast<int>(info->card_layout()), info->has_more_button(),

+ info->show_if_empty());

}

ScopedJavaLocalRef<jobject> NTPSnippetsBridge::GetSuggestionsForCategory(