Don't reposition if shutdown is in progress

Don't reposition if shutdown is in progress

BUG=634572
Committed: https://crrev.com/bbe0bdc738e50b89b5bffb25e431e6b6e75a4249
Cr-Commit-Position: refs/heads/master@{#412675}

[oshima, 2016-08-17 21:23:10]

oshima@chromium.org changed reviewers:
+ varkha@chromium.org

[oshima, 2016-08-17 21:24:35]

Description was changed from

==========
Dont' reposition if shutdown is in progress

BUG=634572
==========

to

==========
Dont' reposition if shutdown is in progress

BUG=634572
==========

[oshima, 2016-08-17 21:24:35]

oshima@chromium.org changed reviewers:
+ skuhne@chromium.org

[oshima, 2016-08-17 21:24:56]

-> skuhne@ in case varkha@ can't review this soon.

[varkha, 2016-08-17 21:49:32]

LGTM with nits and a suggestion / question.

nit: in description:
s/Dont' reposition/Don't reposition windows

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_grid.cc:459: if (window_list_.empty() ||
window_selector_->shutdown())
Should this early exit be in PositionWindows() instead?

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_selector.h (right):

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector.h:78: bool shutdown() const { return
shutdown_; }
nit: consider is_shut_down or finalized() or is_shutting_down() to disambiguate
from WindowSelector::Shutdown() above which is a verb.

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector.h:185: 
Comment?

[oshima, 2016-08-17 21:57:13]

Description was changed from

==========
Dont' reposition if shutdown is in progress

BUG=634572
==========

to

==========
Don't reposition if shutdown is in progress

BUG=634572
==========

[oshima, 2016-08-17 22:00:26]

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_grid.cc (right):

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_grid.cc:459: if (window_list_.empty() ||
window_selector_->shutdown())
On 2016/08/17 21:49:31, varkha wrote:
> Should this early exit be in PositionWindows() instead?

Done.

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
File ash/common/wm/overview/window_selector.h (right):

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector.h:78: bool shutdown() const { return
shutdown_; }
On 2016/08/17 21:49:32, varkha wrote:
> nit: consider is_shut_down or finalized() or is_shutting_down() to
disambiguate
> from WindowSelector::Shutdown() above which is a verb.

Done.

https://codereview.chromium.org/2249853009/diff/1/ash/common/wm/overview/wind...
ash/common/wm/overview/window_selector.h:185: 
On 2016/08/17 21:49:32, varkha wrote:
> Comment?

I changed it to in_shut_down_ and I believe it's self-explanatory now.

[oshima, 2016-08-17 22:00:47]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-08-17 22:00:48]

The patchset sent to the CQ was uploaded after l-g-t-m from varkha@chromium.org
Link to the patchset: https://codereview.chromium.org/2249853009/#ps20001
(title: "addressed")

[commit-bot: I haz the power, 2016-08-17 22:01:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 22:45:09]

Description was changed from

==========
Don't reposition if shutdown is in progress

BUG=634572
==========

to

==========
Don't reposition if shutdown is in progress

BUG=634572
==========

[commit-bot: I haz the power, 2016-08-17 22:45:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 22:49:09]

Description was changed from

==========
Don't reposition if shutdown is in progress

BUG=634572
==========

to

==========
Don't reposition if shutdown is in progress

BUG=634572

Committed: https://crrev.com/bbe0bdc738e50b89b5bffb25e431e6b6e75a4249
Cr-Commit-Position: refs/heads/master@{#412675}
==========

[commit-bot: I haz the power, 2016-08-17 22:49:09]

Patchset 2 (id:??) landed as
https://crrev.com/bbe0bdc738e50b89b5bffb25e431e6b6e75a4249
Cr-Commit-Position: refs/heads/master@{#412675}