Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: ash/common/wm/overview/window_selector.h

Issue 2249853009: Don't reposition if shutdown is in progress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_H_ 5 #ifndef ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_H_
6 #define ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_H_ 6 #define ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 66
67 // Called when |window| is about to get closed. 67 // Called when |window| is about to get closed.
68 void WindowClosing(WindowSelectorItem* window); 68 void WindowClosing(WindowSelectorItem* window);
69 69
70 WindowSelectorDelegate* delegate() { return delegate_; } 70 WindowSelectorDelegate* delegate() { return delegate_; }
71 71
72 bool restoring_minimized_windows() const { 72 bool restoring_minimized_windows() const {
73 return restoring_minimized_windows_; 73 return restoring_minimized_windows_;
74 } 74 }
75 75
76 int text_filter_bottom() { return text_filter_bottom_; } 76 int text_filter_bottom() const { return text_filter_bottom_; }
77
78 bool shutdown() const { return shutdown_; }
varkha 2016/08/17 21:49:32 nit: consider is_shut_down or finalized() or is_sh
oshima 2016/08/17 22:00:26 Done.
77 79
78 // display::DisplayObserver: 80 // display::DisplayObserver:
79 void OnDisplayAdded(const display::Display& display) override; 81 void OnDisplayAdded(const display::Display& display) override;
80 void OnDisplayRemoved(const display::Display& display) override; 82 void OnDisplayRemoved(const display::Display& display) override;
81 void OnDisplayMetricsChanged(const display::Display& display, 83 void OnDisplayMetricsChanged(const display::Display& display,
82 uint32_t metrics) override; 84 uint32_t metrics) override;
83 85
84 // WmWindowObserver: 86 // WmWindowObserver:
85 void OnWindowTreeChanged(WmWindow* window, 87 void OnWindowTreeChanged(WmWindow* window,
86 const TreeChangeParams& params) override; 88 const TreeChangeParams& params) override;
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 // during this overview mode session. 175 // during this overview mode session.
174 size_t num_times_textfield_cleared_; 176 size_t num_times_textfield_cleared_;
175 177
176 // Tracks whether minimized windows are currently being restored for overview 178 // Tracks whether minimized windows are currently being restored for overview
177 // mode. 179 // mode.
178 bool restoring_minimized_windows_; 180 bool restoring_minimized_windows_;
179 181
180 // The distance between the top edge of the screen and the bottom edge of 182 // The distance between the top edge of the screen and the bottom edge of
181 // the text filtering textfield. 183 // the text filtering textfield.
182 int text_filter_bottom_; 184 int text_filter_bottom_;
183 185
varkha 2016/08/17 21:49:32 Comment?
oshima 2016/08/17 22:00:26 I changed it to in_shut_down_ and I believe it's s
186 bool shutdown_ = false;
187
184 DISALLOW_COPY_AND_ASSIGN(WindowSelector); 188 DISALLOW_COPY_AND_ASSIGN(WindowSelector);
185 }; 189 };
186 190
187 } // namespace ash 191 } // namespace ash
188 192
189 #endif // ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_H_ 193 #endif // ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698