Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2249843002: Add a force-offline header to the download page open request. (Closed)

Created:
4 years, 4 months ago by Dmitry Titov
Modified:
4 years, 4 months ago
Reviewers:
jianli
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a force-offline header to the download page open request. This will force offline copy to be loaded even when device is online. BUG=630817 Committed: https://crrev.com/76dda65295540570a8d35f6cc5cc491283fd41cd Cr-Commit-Position: refs/heads/master@{#412070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dmitry Titov
4 years, 4 months ago (2016-08-15 21:23:01 UTC) #2
jianli
lgtm
4 years, 4 months ago (2016-08-15 21:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249843002/1
4 years, 4 months ago (2016-08-15 21:38:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 22:19:57 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 22:24:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76dda65295540570a8d35f6cc5cc491283fd41cd
Cr-Commit-Position: refs/heads/master@{#412070}

Powered by Google App Engine
This is Rietveld 408576698