Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2249843002: Add a force-offline header to the download page open request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
index c1d3328db4fc3a8d6f3d12085e244f1796799409..4622b5175893fe65f31254515610a25189b7a727 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
@@ -14,7 +14,9 @@ import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
import org.chromium.content_public.browser.LoadUrlParams;
import java.util.ArrayList;
+import java.util.HashMap;
import java.util.List;
+import java.util.Map;
/**
* Serves as an interface between Download Home UI and offline page related items that are to be
@@ -128,12 +130,9 @@ public class OfflinePageDownloadBridge {
if (url == null) return;
LoadUrlParams params = new LoadUrlParams(url);
- // TODO(dimich): W/o forcing offline, the page gets redirected to online
- // URL if device is connected. Figure out how to force the offline by
- // observing the request header.
- // Map<String, String> headers = new HashMap<String, String>();
- // headers.put("x-chrome-force-offline", "true");
- // params.setExtraHeaders(headers);
+ Map<String, String> headers = new HashMap<String, String>();
+ headers.put("X-chromium-offline", "reason=download");
+ params.setExtraHeaders(headers);
final TabDelegate tabDelegate = new TabDelegate(false);
tabDelegate.createNewTab(params, TabLaunchType.FROM_LINK, null);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698