net/quic/core/quic_stream_sequencer_test.cc - Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/quic_stream_sequencer_test.cc

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/quic_stream_sequencer_test.cc

diff --git a/net/quic/core/quic_stream_sequencer_test.cc b/net/quic/core/quic_stream_sequencer_test.cc

index 16bee477c606526cc9b93b0d6423a78c43a51326..96aea1e9f0cc26aa51c2b3a7291a1effc860e793 100644

--- a/net/quic/core/quic_stream_sequencer_test.cc

+++ b/net/quic/core/quic_stream_sequencer_test.cc

@@ -548,9 +548,9 @@ TEST_F(QuicStreamSequencerTest, MarkConsumedError) {

// Now, attempt to mark consumed more data than was readable and expect the

// stream to be closed.

EXPECT_CALL(stream_, Reset(QUIC_ERROR_PROCESSING_STREAM));

- EXPECT_DFATAL(sequencer_->MarkConsumed(4),

- "Invalid argument to MarkConsumed."

- " expect to consume: 4, but not enough bytes available.");

+ EXPECT_QUIC_BUG(sequencer_->MarkConsumed(4),

+ "Invalid argument to MarkConsumed."

+ " expect to consume: 4, but not enough bytes available.");

}

TEST_F(QuicStreamSequencerTest, MarkConsumedWithMissingPacket) {

« no previous file with comments | « net/quic/core/quic_spdy_stream_test.cc ('k') | net/quic/core/reliable_quic_stream_test.cc » ('j') | no next file with comments »