Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2249783004: Cleanup: no need to pass Zone around when creating Ast nodes. (Closed)

Created:
4 years, 4 months ago by marja
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup: no need to pass Zone around when creating Ast nodes. They were not using it for anything. Block and FunctionLiteral need the Zone, others don't. BUG= Committed: https://crrev.com/4ba0069694190c860501cc349159502a7f217842 Cr-Commit-Position: refs/heads/master@{#38699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -216 lines) Patch
M src/ast/ast.h View 66 chunks +177 lines, -203 lines 0 comments Download
M src/ast/ast.cc View 5 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Toon Verwaest
wut ... nice :) lgtm
4 years, 4 months ago (2016-08-17 13:03:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249783004/1
4 years, 4 months ago (2016-08-18 08:25:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:27:27 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:27:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ba0069694190c860501cc349159502a7f217842
Cr-Commit-Position: refs/heads/master@{#38699}

Powered by Google App Engine
This is Rietveld 408576698