Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: src/ast/ast.cc

Issue 2249783004: Cleanup: no need to pass Zone around when creating Ast nodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index 4051d33d23a82c60ae93215dc968fecc788f3d8a..06037f4e6d35edad4b5a142c10473a977d3ce6f3 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -163,9 +163,9 @@ bool Statement::IsJump() const {
}
}
-VariableProxy::VariableProxy(Zone* zone, Variable* var, int start_position,
+VariableProxy::VariableProxy(Variable* var, int start_position,
int end_position)
- : Expression(zone, start_position, kVariableProxy),
+ : Expression(start_position, kVariableProxy),
bit_field_(IsThisField::encode(var->is_this()) |
IsAssignedField::encode(false) |
IsResolvedField::encode(false)),
@@ -175,10 +175,10 @@ VariableProxy::VariableProxy(Zone* zone, Variable* var, int start_position,
BindTo(var);
}
-VariableProxy::VariableProxy(Zone* zone, const AstRawString* name,
+VariableProxy::VariableProxy(const AstRawString* name,
Variable::Kind variable_kind, int start_position,
int end_position)
- : Expression(zone, start_position, kVariableProxy),
+ : Expression(start_position, kVariableProxy),
bit_field_(IsThisField::encode(variable_kind == Variable::THIS) |
IsAssignedField::encode(false) |
IsResolvedField::encode(false)),
@@ -186,8 +186,8 @@ VariableProxy::VariableProxy(Zone* zone, const AstRawString* name,
raw_name_(name),
next_unresolved_(nullptr) {}
-VariableProxy::VariableProxy(Zone* zone, const VariableProxy* copy_from)
- : Expression(zone, copy_from->position(), kVariableProxy),
+VariableProxy::VariableProxy(const VariableProxy* copy_from)
+ : Expression(copy_from->position(), kVariableProxy),
bit_field_(copy_from->bit_field_),
end_position_(copy_from->end_position_),
next_unresolved_(nullptr) {
@@ -250,9 +250,9 @@ void ForInStatement::AssignFeedbackVectorSlots(Isolate* isolate,
for_in_feedback_slot_ = spec->AddGeneralSlot();
}
-Assignment::Assignment(Zone* zone, Token::Value op, Expression* target,
- Expression* value, int pos)
- : Expression(zone, pos, kAssignment),
+Assignment::Assignment(Token::Value op, Expression* target, Expression* value,
+ int pos)
+ : Expression(pos, kAssignment),
bit_field_(
IsUninitializedField::encode(false) | KeyTypeField::encode(ELEMENT) |
StoreModeField::encode(STANDARD_STORE) | TokenField::encode(op)),
@@ -935,10 +935,9 @@ Call::CallType Call::GetCallType() const {
return OTHER_CALL;
}
-
-CaseClause::CaseClause(Zone* zone, Expression* label,
- ZoneList<Statement*>* statements, int pos)
- : Expression(zone, pos, kCaseClause),
+CaseClause::CaseClause(Expression* label, ZoneList<Statement*>* statements,
+ int pos)
+ : Expression(pos, kCaseClause),
label_(label),
statements_(statements),
compare_type_(Type::None()) {}
« no previous file with comments | « src/ast/ast.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698