Scan card holder name.

Scan card holder name.

- Show "Scan card" prompt in card holder name field as well as in the
  card number field.

- When scanning the card, use the new card holder name data to populate
  the credit card form.

BUG=637896
Committed: https://crrev.com/19c23f5251de664dec463e4b864e3ef91ff46b16
Cr-Commit-Position: refs/heads/master@{#412600}

[please use gerrit instead, 2016-08-15 19:28:00]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 19:28:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 19:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 19:37:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2016-08-15 20:40:35]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 20:40:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:50:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[please use gerrit instead, 2016-08-15 22:43:15]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 22:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:24:50]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-08-15 23:30:44]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-08-15 23:30:53]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2016-08-15 23:32:21]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2016-08-15 23:32:22]

Evan, ptal components/autofill and chrome/browser/ui/autofill.

[please use gerrit instead, 2016-08-15 23:34:20]

rouslan@chromium.org changed reviewers:
+ tedchoc@chromium.org

[please use gerrit instead, 2016-08-15 23:34:21]

Ted, ptal chrome/browser/ui/android and chrome/android.

[please use gerrit instead, 2016-08-15 23:35:13]

rouslan@chromium.org changed reviewers:
+ michaeln@chromium.org

[please use gerrit instead, 2016-08-15 23:35:13]

michaeln, ptal chrome/browser/browsing_data/autofill_counter_browsertest.cc.

[Ted C, 2016-08-16 00:20:32]

On 2016/08/15 23:35:13, rouslan wrote:
> michaeln, ptal chrome/browser/browsing_data/autofill_counter_browsertest.cc.

lgtm - android

[michaeln, 2016-08-16 00:29:50]

> > michaeln, ptal chrome/browser/browsing_data/autofill_counter_browsertest.cc.

browsing_data lgtm

[Evan Stade, 2016-08-16 00:33:35]

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_external_delegate.h (right):

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_external_delegate.h:94: void
OnCreditCardScanned(const base::string16& card_holder_name,
is there a reason this doesn't just take a CreditCard?

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:49: CreditCard(const
base::string16& card_holder_name,
I don't see why we need a special constructor for this one use case

[please use gerrit instead, 2016-08-16 03:05:54]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 03:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-08-16 03:14:25]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-08-16 03:14:35]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-08-16 03:14:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 03:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 03:23:50]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[please use gerrit instead, 2016-08-16 21:17:23]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:17:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-08-16 21:23:41]

Patchset #2 (id:80001) has been deleted

[please use gerrit instead, 2016-08-16 22:03:19]

Evan, ptal patch 2.

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_external_delegate.h (right):

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_external_delegate.h:94: void
OnCreditCardScanned(const base::string16& card_holder_name,
On 2016/08/16 00:33:35, Evan Stade wrote:
> is there a reason this doesn't just take a CreditCard?

No reason. Changed to take a card.

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:49: CreditCard(const
base::string16& card_holder_name,
On 2016/08/16 00:33:35, Evan Stade wrote:
> I don't see why we need a special constructor for this one use case

Leaving the original constructor alone.

[commit-bot: I haz the power, 2016-08-16 22:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:05:43]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-08-17 06:30:57]

lgtm

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_external_delegate.h (right):

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_external_delegate.h:94: void
OnCreditCardScanned(const base::string16& card_holder_name,
On 2016/08/16 22:03:18, rouslan wrote:
> On 2016/08/16 00:33:35, Evan Stade wrote:
> > is there a reason this doesn't just take a CreditCard?
> 
> No reason. Changed to take a card.

nice

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:49: CreditCard(const
base::string16& card_holder_name,
On 2016/08/16 22:03:19, rouslan wrote:
> On 2016/08/16 00:33:35, Evan Stade wrote:
> > I don't see why we need a special constructor for this one use case
> 
> Leaving the original constructor alone.

cool, but I was actually hoping you'd delete it completely. It only appears to
be used in one place in production code, which is the card scanner. I don't
really think we should be pushing such specific (one off) uses into
constructors.

[please use gerrit instead, 2016-08-17 18:16:17]

Sending to cq.

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/2249773002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:49: CreditCard(const
base::string16& card_holder_name,
On 2016/08/17 06:30:57, Evan Stade wrote:
> cool, but I was actually hoping you'd delete it completely. It only appears to
> be used in one place in production code, which is the card scanner. I don't
> really think we should be pushing such specific (one off) uses into
> constructors.

This constructor is used in tons of tests, so it would be better to delete it in
a separate CL.

[please use gerrit instead, 2016-08-17 18:47:26]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-08-17 18:47:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2249773002/#ps100001
(title: "Pass CreditCard, don't alter the constructor.")

[commit-bot: I haz the power, 2016-08-17 18:47:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 18:52:43]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-08-17 18:58:14]

Description was changed from

==========
Scan card holder name.

- Show "Scan card" prompt in card holder name field as well as in the
  card number field.

- When scanning the card, use the new card holder name data to populate
  the credit card form.

BUG=637896
==========

to

==========
Scan card holder name.

- Show "Scan card" prompt in card holder name field as well as in the
  card number field.

- When scanning the card, use the new card holder name data to populate
  the credit card form.

BUG=637896

Committed: https://crrev.com/19c23f5251de664dec463e4b864e3ef91ff46b16
Cr-Commit-Position: refs/heads/master@{#412600}
==========

[commit-bot: I haz the power, 2016-08-17 18:58:15]

Patchset 2 (id:??) landed as
https://crrev.com/19c23f5251de664dec463e4b864e3ef91ff46b16
Cr-Commit-Position: refs/heads/master@{#412600}