Scan card holder name.

components/autofill/core/browser/credit_card.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 
 #include <iosfwd>
 #include <string>
 #include <utility>
@@ skipping 28 matching lines @@
     FULL_SERVER_CARD,
   };
 
   // The status of this credit card. Only used for server cards.
   enum ServerStatus {
     EXPIRED,
     OK,
   };
 
   CreditCard(const std::string& guid, const std::string& origin);
-  CreditCard(const base::string16& card_number,
+  CreditCard(const base::string16& card_holder_name,

[Evan Stade, 2016/08/16 00:33:35]

I don't see why we need a special constructor for this one use case

[please use gerrit instead, 2016/08/16 22:03:19]

Leaving the original constructor alone.

[Evan Stade, 2016/08/17 06:30:57]

cool, but I was actually hoping you'd delete it completely. It only appears to
be used in one place in production code, which is the card scanner. I don't
really think we should be pushing such specific (one off) uses into
constructors.

[please use gerrit instead, 2016/08/17 18:16:17]

This constructor is used in tons of tests, so it would be better to delete it in
a separate CL.

+             const base::string16& card_number,
              int expiration_month,
              int expiration_year);
 
   // Creates a server card.  The type must be MASKED_SERVER_CARD or
   // FULL_SERVER_CARD.
   CreditCard(RecordType type, const std::string& server_id);
 
   // For use in STL containers.
   CreditCard();
   CreditCard(const CreditCard& credit_card);
@@ skipping 208 matching lines @@
 extern const char kDiscoverCard[];
 extern const char kGenericCard[];
 extern const char kJCBCard[];
 extern const char kMasterCard[];
 extern const char kUnionPay[];
 extern const char kVisaCard[];
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_