|
|
Created:
4 years, 4 months ago by servolk Modified:
4 years, 4 months ago CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMark HTMLMediaElement media tracks functionality as stable
This will make HTMLMediaElement media tracks accessible and usable
by default, without enable-experimental-web-platform-features flag.
Intent to ship notification:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Yk8u329AmIs
BUG=249427, 249428
Patch Set 1 #Patch Set 2 : Update webexposed test expectations #Patch Set 3 : Updated platform/RuntimeEnabledFeatures.in #
Total comments: 3
Patch Set 4 : Just mark the feature as stable #Patch Set 5 : Updated virtual/stable/webexposed test expectations #
Messages
Total messages: 43 (34 generated)
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable media tracks functionality by default Currently media tracks are behind the experimental flag and are not available by default. This change will remove the flag and will make media tracks accessible by default. BUG=249427,249428 ========== to ========== Enable media tracks functionality by default Currently media tracks are behind the experimental flag and are not available by default. This change will remove the flag and will make media tracks accessible by default. BUG=249427,249428 ==========
servolk@chromium.org changed reviewers: + foolip@chromium.org, mlamouri@chromium.org, wolenetz@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left): https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:33: AudioVideoTracks status=experimental Usually, we mark the status as "stable" for a release or two before removing the flag entirely. Is there a reason I'm missing why you prefer to drop the flag?
https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left): https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:33: AudioVideoTracks status=experimental On 2016/08/17 09:09:39, Mounir Lamouri wrote: > Usually, we mark the status as "stable" for a release or two before removing the > flag entirely. Is there a reason I'm missing why you prefer to drop the flag? No reason, I just have no prior experience with moving features to stable and based on the comment at line 17 above, which says '... stable features should be rare ...' I've thought it would be better to remove the flag entirely, since there are few places that need to be updated (I believe I got every single place that need to be updated in this CL) and so it would be easy to remove. I can mark the feature as 'stable' for now if that's the preferred way.
https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left): https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:33: AudioVideoTracks status=experimental On 2016/08/17 15:56:22, servolk wrote: > On 2016/08/17 09:09:39, Mounir Lamouri wrote: > > Usually, we mark the status as "stable" for a release or two before removing > the > > flag entirely. Is there a reason I'm missing why you prefer to drop the flag? > > No reason, I just have no prior experience with moving features to stable and > based on the comment at line 17 above, which says '... stable features should be > rare ...' I've thought it would be better to remove the flag entirely, since > there are few places that need to be updated (I believe I got every single place > that need to be updated in this CL) and so it would be easy to remove. I can > mark the feature as 'stable' for now if that's the preferred way. +1 to marking stable rather than ripping all the gates out. Note that I'm investigating an MSE audio/videoTrack-related w3c test suite failure at the moment (it looks like we need to fire 'change' at {audio,video}Tracks when selected/enabled track changes. Or maybe the new test suite test is doing something wrong. I'll fix one or both of Chromium and w3c test suite shortly. Late changes like what I'll probably need to do further justify marking 'stable' instead of ripping out the gates.
On 2016/08/18 00:10:50, wolenetz wrote: > https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left): > > https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:33: > AudioVideoTracks status=experimental > On 2016/08/17 15:56:22, servolk wrote: > > On 2016/08/17 09:09:39, Mounir Lamouri wrote: > > > Usually, we mark the status as "stable" for a release or two before removing > > the > > > flag entirely. Is there a reason I'm missing why you prefer to drop the > flag? > > > > No reason, I just have no prior experience with moving features to stable and > > based on the comment at line 17 above, which says '... stable features should > be > > rare ...' I've thought it would be better to remove the flag entirely, since > > there are few places that need to be updated (I believe I got every single > place > > that need to be updated in this CL) and so it would be easy to remove. I can > > mark the feature as 'stable' for now if that's the preferred way. > > +1 to marking stable rather than ripping all the gates out. > Note that I'm investigating an MSE audio/videoTrack-related w3c test suite > failure at the moment (it looks like we need to fire 'change' at > {audio,video}Tracks when selected/enabled track changes. Or maybe the new test > suite test is doing something wrong. I'll fix one or both of Chromium and w3c > test suite shortly. Late changes like what I'll probably need to do further > justify marking 'stable' instead of ripping out the gates. Note: The failing w3c tests are within https://github.com/w3c/web-platform-tests/pull/3182.
Description was changed from ========== Enable media tracks functionality by default Currently media tracks are behind the experimental flag and are not available by default. This change will remove the flag and will make media tracks accessible by default. BUG=249427,249428 ========== to ========== Mark HTMLMediaElement media tracks functionality as stable This will make HTMLMediaElement media tracks accessible and usable by default, without enable-experimental-web-platform-features flag. BUG=249427,249428 ==========
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/18 00:12:42, wolenetz wrote: > On 2016/08/18 00:10:50, wolenetz wrote: > > > https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... > > File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (left): > > > > > https://codereview.chromium.org/2249763003/diff/40001/third_party/WebKit/Sour... > > third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:33: > > AudioVideoTracks status=experimental > > On 2016/08/17 15:56:22, servolk wrote: > > > On 2016/08/17 09:09:39, Mounir Lamouri wrote: > > > > Usually, we mark the status as "stable" for a release or two before > removing > > > the > > > > flag entirely. Is there a reason I'm missing why you prefer to drop the > > flag? > > > > > > No reason, I just have no prior experience with moving features to stable > and > > > based on the comment at line 17 above, which says '... stable features > should > > be > > > rare ...' I've thought it would be better to remove the flag entirely, since > > > there are few places that need to be updated (I believe I got every single > > place > > > that need to be updated in this CL) and so it would be easy to remove. I can > > > mark the feature as 'stable' for now if that's the preferred way. > > > > +1 to marking stable rather than ripping all the gates out. > > Note that I'm investigating an MSE audio/videoTrack-related w3c test suite > > failure at the moment (it looks like we need to fire 'change' at > > {audio,video}Tracks when selected/enabled track changes. Or maybe the new test > > suite test is doing something wrong. I'll fix one or both of Chromium and w3c > > test suite shortly. Late changes like what I'll probably need to do further > > justify marking 'stable' instead of ripping out the gates. > > Note: The failing w3c tests are within > https://github.com/w3c/web-platform-tests/pull/3182. Ok, I've updated the CL to just flip the switch in RuntimeEnabledFeatures.in
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
lgtm Can you link to the Intent to Ship email?
Description was changed from ========== Mark HTMLMediaElement media tracks functionality as stable This will make HTMLMediaElement media tracks accessible and usable by default, without enable-experimental-web-platform-features flag. BUG=249427,249428 ========== to ========== Mark HTMLMediaElement media tracks functionality as stable This will make HTMLMediaElement media tracks accessible and usable by default, without enable-experimental-web-platform-features flag. Intent to ship notification: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Yk8u329AmIs BUG=249427,249428 ==========
On 2016/08/18 13:30:08, Mounir Lamouri wrote: > lgtm > > Can you link to the Intent to Ship email? Done.
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm % approvals on the intent to ship from API owners. Note that https://bugs.chromium.org/p/chromium/issues/detail?id=639151 shows that some of the tracks functionality required for MSE is still missing. |