[DevTools] Rename entities in js_protocol, remove deprecated ones.

[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947
Committed: https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821
Cr-Commit-Position: refs/heads/master@{#412364}

[dgozman, 2016-08-15 18:50:19]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-08-15 18:50:19]

Take a look please.

[pfeldman, 2016-08-15 19:09:10]

lgtm

[dgozman, 2016-08-15 19:22:06]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-08-15 19:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:56:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-15 21:00:50]

Description was changed from

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947
==========

to

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947

Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
Cr-Commit-Position: refs/heads/master@{#412043}
==========

[commit-bot: I haz the power, 2016-08-15 21:00:51]

Patchset 1 (id:??) landed as
https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
Cr-Commit-Position: refs/heads/master@{#412043}

[Bret, 2016-08-15 21:31:28]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2249663003/ by bsep@chromium.org.

The reason for reverting is: Compile failed on Linux ChromiumOS GN
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no
member named 'Run' in 'headless::runtime::ExperimentalDomain'
    devtools_client_->GetRuntime()->GetExperimental()->Run(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^
../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no
member named 'RunParams' in namespace 'headless::runtime'
        runtime::RunParams::Builder().Build());
        ~~~~~~~~~^.

[dgozman, 2016-08-15 21:32:13]

On 2016/08/15 21:31:28, Bret Sepulveda wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2249663003/ by mailto:bsep@chromium.org.
> 
> The reason for reverting is: Compile failed on Linux ChromiumOS GN
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> 
> ../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no
> member named 'Run' in 'headless::runtime::ExperimentalDomain'
>     devtools_client_->GetRuntime()->GetExperimental()->Run(
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^
> ../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no
> member named 'RunParams' in namespace 'headless::runtime'
>         runtime::RunParams::Builder().Build());
>         ~~~~~~~~~^.

How did this pass CQ?

[dgozman, 2016-08-15 23:27:15]

Description was changed from

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947

Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
Cr-Commit-Position: refs/heads/master@{#412043}
==========

to

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947
==========

[dgozman, 2016-08-15 23:45:50]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-08-15 23:45:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2249743002/#ps20001
(title: "headless")

[commit-bot: I haz the power, 2016-08-15 23:46:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:52:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-08-16 00:21:42]

dgozman@chromium.org changed reviewers:
+ skyostil@chromium.org

[dgozman, 2016-08-16 00:21:42]

Sami, could you please take a look at headless test change?

[Sami, 2016-08-16 10:10:11]

On 2016/08/16 00:21:42, dgozman wrote:
> Sami, could you please take a look at headless test change?

lgtm, thanks for the fix.

FWIW we are in the process of adding the headless bot on the CQ so in the future
this kind of stuff will be caught.

[dgozman, 2016-08-16 14:23:57]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-08-16 14:24:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 14:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 14:29:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-08-16 20:19:27]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-08-16 20:19:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2249743002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-08-16 20:19:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 22:49:20]

Description was changed from

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947
==========

to

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947
==========

[commit-bot: I haz the power, 2016-08-16 22:49:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-16 22:50:38]

Description was changed from

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947
==========

to

==========
[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG=635947

Committed: https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821
Cr-Commit-Position: refs/heads/master@{#412364}
==========

[commit-bot: I haz the power, 2016-08-16 22:50:39]

Patchset 3 (id:??) landed as
https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821
Cr-Commit-Position: refs/heads/master@{#412364}