headless/lib/headless_devtools_client_browsertest.cc - Issue 2249743002: [DevTools] Rename entities in js_protocol, remove deprecated ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2249743002: [DevTools] Rename entities in js_protocol, remove deprecated ones. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/lib/headless_devtools_client_browsertest.cc

diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc

index 9eb22d10abb2367addd18a2beb2fab4c4f411a7d..5523b159f96667e7c4e03b2dec3733c88d7f627f 100644

--- a/headless/lib/headless_devtools_client_browsertest.cc

+++ b/headless/lib/headless_devtools_client_browsertest.cc

@@ -174,8 +174,8 @@ class HeadlessDevToolsClientExperimentalTest

void RunDevTooledTest() override {

EXPECT_TRUE(embedded_test_server()->Start());

// Check that experimental commands require parameter objects.

- devtools_client_->GetRuntime()->GetExperimental()->Run(

- runtime::RunParams::Builder().Build());

+ devtools_client_->GetRuntime()->GetExperimental()->RunIfWaitingForDebugger(

+ runtime::RunIfWaitingForDebuggerParams::Builder().Build());

devtools_client_->GetPage()->GetExperimental()->AddObserver(this);

devtools_client_->GetPage()->Enable();

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html » ('j') | no next file with comments »