Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. (patchset #1 id:1 of https://codereview.chromium.org/2249743002/ )
Reason for revert:
Compile failed on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/44080
../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no member named 'Run' in 'headless::runtime::ExperimentalDomain'
devtools_client_->GetRuntime()->GetExperimental()->Run(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no member named 'RunParams' in namespace 'headless::runtime'
runtime::RunParams::Builder().Build());
~~~~~~~~~^
Original issue's description:
> [DevTools] Rename entities in js_protocol, remove deprecated ones.
>
> BUG=635947
>
> Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
> Cr-Commit-Position: refs/heads/master@{#412043}
TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635947
Committed: https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da
Cr-Commit-Position: refs/heads/master@{#412052}
Description was changed from ========== Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. ...
4 years, 4 months ago
(2016-08-15 21:33:08 UTC)
#4
Message was sent while issue was closed.
Description was changed from
==========
Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones.
(patchset #1 id:1 of https://codereview.chromium.org/2249743002/ )
Reason for revert:
Compile failed on Linux ChromiumOS GN
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no
member named 'Run' in 'headless::runtime::ExperimentalDomain'
devtools_client_->GetRuntime()->GetExperimental()->Run(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no
member named 'RunParams' in namespace 'headless::runtime'
runtime::RunParams::Builder().Build());
~~~~~~~~~^
Original issue's description:
> [DevTools] Rename entities in js_protocol, remove deprecated ones.
>
> BUG=635947
>
> Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
> Cr-Commit-Position: refs/heads/master@{#412043}
TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635947
==========
to
==========
Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones.
(patchset #1 id:1 of https://codereview.chromium.org/2249743002/ )
Reason for revert:
Compile failed on Linux ChromiumOS GN
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no
member named 'Run' in 'headless::runtime::ExperimentalDomain'
devtools_client_->GetRuntime()->GetExperimental()->Run(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no
member named 'RunParams' in namespace 'headless::runtime'
runtime::RunParams::Builder().Build());
~~~~~~~~~^
Original issue's description:
> [DevTools] Rename entities in js_protocol, remove deprecated ones.
>
> BUG=635947
>
> Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
> Cr-Commit-Position: refs/heads/master@{#412043}
TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635947
==========
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago
(2016-08-15 21:33:09 UTC)
#5
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. ...
4 years, 4 months ago
(2016-08-15 21:46:23 UTC)
#6
Message was sent while issue was closed.
Description was changed from
==========
Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones.
(patchset #1 id:1 of https://codereview.chromium.org/2249743002/ )
Reason for revert:
Compile failed on Linux ChromiumOS GN
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no
member named 'Run' in 'headless::runtime::ExperimentalDomain'
devtools_client_->GetRuntime()->GetExperimental()->Run(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no
member named 'RunParams' in namespace 'headless::runtime'
runtime::RunParams::Builder().Build());
~~~~~~~~~^
Original issue's description:
> [DevTools] Rename entities in js_protocol, remove deprecated ones.
>
> BUG=635947
>
> Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
> Cr-Commit-Position: refs/heads/master@{#412043}
TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635947
==========
to
==========
Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones.
(patchset #1 id:1 of https://codereview.chromium.org/2249743002/ )
Reason for revert:
Compile failed on Linux ChromiumOS GN
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no
member named 'Run' in 'headless::runtime::ExperimentalDomain'
devtools_client_->GetRuntime()->GetExperimental()->Run(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no
member named 'RunParams' in namespace 'headless::runtime'
runtime::RunParams::Builder().Build());
~~~~~~~~~^
Original issue's description:
> [DevTools] Rename entities in js_protocol, remove deprecated ones.
>
> BUG=635947
>
> Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
> Cr-Commit-Position: refs/heads/master@{#412043}
TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635947
Committed: https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da
Cr-Commit-Position: refs/heads/master@{#412052}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da Cr-Commit-Position: refs/heads/master@{#412052}
4 years, 4 months ago
(2016-08-15 21:46:24 UTC)
#7
Issue 2249663003: Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones.
(Closed)
Created 4 years, 4 months ago by Bret
Modified 4 years, 4 months ago
Reviewers: pfeldman, dgozman
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0
Chromium Code Reviews
Issue
2249663003:
Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. (Closed)
