third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h - Issue 2249663003: Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 2249663003: Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

index a6fb5382853514f085320a2b66759394fe7fbc4a..9a06c314fe84626a83ff89e99fbc81e82bcabbcc 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

@@ -54,7 +54,7 @@

void enable(ErrorString*) override;

void disable(ErrorString*) override;

void setBreakpointsActive(ErrorString*, bool active) override;

- void setSkipAllPauses(ErrorString*, bool skip) override;

+ void setSkipAllPauses(ErrorString*, bool skipped) override;

void setBreakpointByUrl(ErrorString*,

int lineNumber,

const Maybe<String16>& optionalURL,

@@ -80,7 +80,7 @@

void setScriptSource(ErrorString*,

const String16& inScriptId,

const String16& inScriptSource,

- const Maybe<bool>& dryRun,

+ const Maybe<bool>& inPreview,

Maybe<protocol::Array<protocol::Debugger::CallFrame>>* optOutCallFrames,

Maybe<bool>* optOutStackChanged,

Maybe<protocol::Runtime::StackTrace>* optOutAsyncStackTrace,

@@ -101,7 +101,7 @@

const String16& expression,

const Maybe<String16>& objectGroup,

const Maybe<bool>& includeCommandLineAPI,

- const Maybe<bool>& silent,

+ const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

std::unique_ptr<protocol::Runtime::RemoteObject>* result,