Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2249633005: In deps_updater.py, only use Rietveld refresh token if given. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In deps_updater.py, only use Rietveld refresh token if given. In general, when `update-w3c-deps --auto-import` is run, it should only use the Rietveld authentication when given. This change makes it so that if the script is run on a user's workstation, then that user's credentials may be used. BUG=629275 Committed: https://crrev.com/f4d25a5140a064d50a5c348acf7697219b2be3da Cr-Commit-Position: refs/heads/master@{#412619}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
Note, I'm expected this will probably have to be rebased and updated based on other ...
4 years, 4 months ago (2016-08-16 23:38:02 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-17 00:08:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249633005/20001
4 years, 4 months ago (2016-08-17 18:40:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 20:00:48 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 20:10:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4d25a5140a064d50a5c348acf7697219b2be3da
Cr-Commit-Position: refs/heads/master@{#412619}

Powered by Google App Engine
This is Rietveld 408576698