Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2355)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2249633005: In deps_updater.py, only use Rietveld refresh token if given. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index 754a26b70db86242847cd944534ade5470f5404a..e023b9dec220424c3c16bc647ae1a5760f65b69c 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -299,7 +299,6 @@ class DepsUpdater(object):
return False
return True
-
def get_directory_owners_to_cc(self):
"""Returns a list of email addresses to CC for the current import."""
self.print_('## Gathering directory owners emails to CC.')
@@ -401,5 +400,7 @@ class DepsUpdater(object):
self.run([self.host.executable, script_path])
message = '\'Modifies TestExpectations and/or downloads new baselines for tests\''
self.check_run(['git', 'commit', '-a', '-m', message])
- self.check_run(['git', 'cl', 'upload', '-m', message, '--rietveld'
- '--auth-refresh-token-json', self.auth_refresh_token_json])
+ command = ['git', 'cl', 'upload', '-m', message, '--rietveld']
+ if self.auth_refresh_token_json:
+ command += ['--auth-refresh-token-json', self.auth_refresh_token_json]
+ self.check_run(command)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698