Source/core/html/HTMLFormElement.h - Issue 224963005: Refactoring: Removing variable m_shouldSubmit from HTMLFormElement.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 224963005: Refactoring: Removing variable m_shouldSubmit from HTMLFormElement.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changing return type of HTMLFormElement::prepareForSubmission from bool to void Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormElement.h

diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h

index bcff831b2393cd6ed40888a93e3cf1f29829112e..14011015f4195e0ffab6fc6b8296137dbf25031d 100644

--- a/Source/core/html/HTMLFormElement.h

+++ b/Source/core/html/HTMLFormElement.h

@@ -70,7 +70,7 @@ public:

WeakPtr<HTMLFormElement> createWeakPtr();

void didAssociateByParser();

- bool prepareForSubmission(Event*);

+ void prepareForSubmission(Event*);

void submit();

void submitFromJavaScript();

void reset();

@@ -171,7 +171,6 @@ private:

bool m_didFinishParsingChildren;

bool m_wasUserSubmitted;

- bool m_shouldSubmit;

bool m_isInResetFunction;

« no previous file with comments | « no previous file | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »