Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/core/html/HTMLFormElement.h

Issue 224963005: Refactoring: Removing variable m_shouldSubmit from HTMLFormElement.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changing return type of HTMLFormElement::prepareForSubmission from bool to void Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 bool shouldAutocomplete() const; 64 bool shouldAutocomplete() const;
65 65
66 void associate(FormAssociatedElement&); 66 void associate(FormAssociatedElement&);
67 void disassociate(FormAssociatedElement&); 67 void disassociate(FormAssociatedElement&);
68 void associate(HTMLImageElement&); 68 void associate(HTMLImageElement&);
69 void disassociate(HTMLImageElement&); 69 void disassociate(HTMLImageElement&);
70 WeakPtr<HTMLFormElement> createWeakPtr(); 70 WeakPtr<HTMLFormElement> createWeakPtr();
71 void didAssociateByParser(); 71 void didAssociateByParser();
72 72
73 bool prepareForSubmission(Event*); 73 void prepareForSubmission(Event*);
74 void submit(); 74 void submit();
75 void submitFromJavaScript(); 75 void submitFromJavaScript();
76 void reset(); 76 void reset();
77 77
78 void setDemoted(bool); 78 void setDemoted(bool);
79 79
80 void submitImplicitly(Event*, bool fromImplicitSubmissionTrigger); 80 void submitImplicitly(Event*, bool fromImplicitSubmissionTrigger);
81 81
82 String name() const; 82 String name() const;
83 83
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 Vector<FormAssociatedElement*> m_associatedElements; 164 Vector<FormAssociatedElement*> m_associatedElements;
165 // Do not access m_imageElements directly. Use imageElements() instead. 165 // Do not access m_imageElements directly. Use imageElements() instead.
166 Vector<HTMLImageElement*> m_imageElements; 166 Vector<HTMLImageElement*> m_imageElements;
167 WeakPtrFactory<HTMLFormElement> m_weakPtrFactory; 167 WeakPtrFactory<HTMLFormElement> m_weakPtrFactory;
168 bool m_associatedElementsAreDirty; 168 bool m_associatedElementsAreDirty;
169 bool m_imageElementsAreDirty; 169 bool m_imageElementsAreDirty;
170 bool m_hasElementsAssociatedByParser; 170 bool m_hasElementsAssociatedByParser;
171 bool m_didFinishParsingChildren; 171 bool m_didFinishParsingChildren;
172 172
173 bool m_wasUserSubmitted; 173 bool m_wasUserSubmitted;
174 bool m_shouldSubmit;
175 174
176 bool m_isInResetFunction; 175 bool m_isInResetFunction;
177 176
178 bool m_wasDemoted; 177 bool m_wasDemoted;
179 178
180 void requestAutocompleteTimerFired(Timer<HTMLFormElement>*); 179 void requestAutocompleteTimerFired(Timer<HTMLFormElement>*);
181 180
182 WillBePersistentHeapVector<RefPtrWillBeMember<Event> > m_pendingAutocomplete Events; 181 WillBePersistentHeapVector<RefPtrWillBeMember<Event> > m_pendingAutocomplete Events;
183 Timer<HTMLFormElement> m_requestAutocompleteTimer; 182 Timer<HTMLFormElement> m_requestAutocompleteTimer;
184 }; 183 };
185 184
186 } // namespace WebCore 185 } // namespace WebCore
187 186
188 #endif // HTMLFormElement_h 187 #endif // HTMLFormElement_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698