Refactoring: Removing variable m_shouldSubmit from HTMLFormElement.cpp

Refactoring: Removing variable m_shouldSubmit from HTMLFormElement.cpp

Variable "m_shouldSubmit" is only set to true if the condition dispatchEvent(Event::createCancelableBubble(EventTypeNames::submit)) 
returns true in api prepareForSubmission. And on becoming true it just submit the form. 
Rest everywhere m_shouldSubmit is false. So this patch removes the variable m_shouldSubmit completely and 
change the return type of HTMLFormElement::prepareForSubmission from bool to void.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171008

[harpreet.sk, 2014-04-04 10:54:38]

Please take a look.

[tkent, 2014-04-07 01:35:55]

Why do you think m_shouldSubmit is unused?

[harpreet.sk, 2014-04-07 07:23:58]

On 2014/04/07 01:35:55, tkent wrote:
> Why do you think m_shouldSubmit is unused?


m_shouldSubmit is only set to true in the api prepareForSubmission only if the
condition dispatchEvent(Event::createCancelableBubble(EventTypeNames::submit))
will retuen true. Then soon after this line the variable m_shouldSubmit is check
whether it's true or false and based on that it submit the form. so I thought of
merging these two checks into one. Since after merging these two checks the
variable m_shouldSubmit is false everywhere and it is not checked anywhere
that's why i thought i should remove this variable.

[tkent, 2014-04-07 07:49:15]

On 2014/04/07 07:23:58, harpreet.sk wrote:
> On 2014/04/07 01:35:55, tkent wrote:
> > Why do you think m_shouldSubmit is unused?
> 
> 
> m_shouldSubmit is only set to true in the api prepareForSubmission only if the
> condition dispatchEvent(Event::createCancelableBubble(EventTypeNames::submit))
> will retuen true. Then soon after this line the variable m_shouldSubmit is
check
> whether it's true or false and based on that it submit the form. so I thought
of
> merging these two checks into one. Since after merging these two checks the
> variable m_shouldSubmit is false everywhere and it is not checked anywhere
> that's why i thought i should remove this variable.

The CL description should explain it.

Now HTMLFormElement::prepareForSubmission always return false.  It can be void.

[harpreet.sk, 2014-04-07 11:02:02]

On 2014/04/07 07:49:15, tkent wrote:

> The CL description should explain it.
> 
> Now HTMLFormElement::prepareForSubmission always return false.  It can be
void.



Patch set 2 is uploaded with return type of
HTMLFormElement::prepareForSubmission to be void. Please take a look.

[tkent, 2014-04-08 00:04:36]

lgtm

[commit-bot: I haz the power, 2014-04-08 00:04:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/224963005/20001

[commit-bot: I haz the power, 2014-04-08 01:11:39]

Change committed as 171008