Revert 261559 "Create new app_shell.gyp for app_shell targets."

Revert 261559 "Create new app_shell.gyp for app_shell targets."

> Create new app_shell.gyp for app_shell targets.
> 
> This moves app_shell GYP entries from a chrome.gyp include into
> a new apps/shell/app_shell.gyp.
> 
> It also breaks down dependencies with more granularity and separates
> temporary, undesirable app_shell_lib dependencies from acceptable ones.
> 
> BUG=359678
> TBR=yoz@chromium.org for extensions.gyp
> 
> Review URL: https://codereview.chromium.org/223613005

TBR=rockot@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261595

[Ken Rockot(use gerrit already), 2014-04-04 00:14:39]

Committed patchset #1 manually as r261595 (tree was closed).

[tfarina, 2014-04-04 01:18:36]

Looks like you manually reverted this.

James, Yoyo, fyi.

Btw, you forgot to include the reason for the revert.

What broke that led you to revert it?

[Ken Rockot(use gerrit already), 2014-04-04 02:16:40]

Sorry, the app_shell_temporary_deps target was broken on some builders. It
was (incorrectly) a static_library target with no sources. The result was a
builder attempting to link against the non-existent library.


On Thu, Apr 3, 2014 at 6:18 PM, <tfarina@chromium.org> wrote:

> Looks like you manually reverted this.
>
> James, Yoyo, fyi.
>
> Btw, you forgot to include the reason for the revert.
>
> What broke that led you to revert it?
>
> https://codereview.chromium.org/224963002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2014-04-04 02:18:17]

FYI here is a CL to reland the new gyp file without the error in question:
https://codereview.chromium.org/225023002/


On Thu, Apr 3, 2014 at 7:16 PM, Ken Rockot <rockot@chromium.org> wrote:

> Sorry, the app_shell_temporary_deps target was broken on some builders. It
> was (incorrectly) a static_library target with no sources. The result was a
> builder attempting to link against the non-existent library.
>
>
> On Thu, Apr 3, 2014 at 6:18 PM, <tfarina@chromium.org> wrote:
>
>> Looks like you manually reverted this.
>>
>> James, Yoyo, fyi.
>>
>> Btw, you forgot to include the reason for the revert.
>>
>> What broke that led you to revert it?
>>
>> https://codereview.chromium.org/224963002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[James Cook, 2014-04-04 03:39:11]

On 2014/04/04 02:18:17, Ken Rockot wrote:
> FYI here is a CL to reland the new gyp file without the error in question:
> https://codereview.chromium.org/225023002/
> 
> 
> On Thu, Apr 3, 2014 at 7:16 PM, Ken Rockot <mailto:rockot@chromium.org> wrote:
> 
> > Sorry, the app_shell_temporary_deps target was broken on some builders. It
> > was (incorrectly) a static_library target with no sources. The result was a
> > builder attempting to link against the non-existent library.
> >
> >
> > On Thu, Apr 3, 2014 at 6:18 PM, <mailto:tfarina@chromium.org> wrote:
> >
> >> Looks like you manually reverted this.
> >>
> >> James, Yoyo, fyi.
> >>
> >> Btw, you forgot to include the reason for the revert.
> >>
> >> What broke that led you to revert it?
> >>
> >> https://codereview.chromium.org/224963002/
> >>
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Did it break the Windows builder?  If Windows is slowing us down we should just
stop building app_shell on Windows.  You could let Hokein know as a courtesy but
I doubt we'll ship on Windows any time soon.