Create new app_shell.gyp for app_shell targets.

Create new app_shell.gyp for app_shell targets.

This moves app_shell GYP entries from a chrome.gyp include into
a new apps/shell/app_shell.gyp.

It also breaks down dependencies with more granularity and separates
temporary, undesirable app_shell_lib dependencies from acceptable ones.

BUG=359678
TBR=yoz@chromium.org for extensions.gyp

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261559

[Ken Rockot(use gerrit already), 2014-04-03 19:12:42]

PTAL. Addressed comments from the other CL and split the GYP move.

[James Cook, 2014-04-03 20:06:44]

LGTM with nits

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp
File apps/shell/app_shell.gyp (right):

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:52: # In this case, "temporary" means until the
//extensions houses all code
nit: "until //extensions" or "until the //extensions module"

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:54: # destroyed.
Can you either file a bug for removing these dependencies, or reference another
bug about removing them, and put the bug in the comment here?

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:86: # TODO(rockot): Dependencies above this line are
temporary.
This ordering SGTM

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:103:
'<(DEPTH)/third_party/WebKit/public/blink.gyp:blink',
nit: alphabetize above

[Ken Rockot(use gerrit already), 2014-04-03 20:11:34]

Wooho

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp
File apps/shell/app_shell.gyp (right):

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:52: # In this case, "temporary" means until the
//extensions houses all code
On 2014/04/03 20:06:45, James Cook wrote:
> nit: "until //extensions" or "until the //extensions module"

Done.

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:54: # destroyed.
On 2014/04/03 20:06:45, James Cook wrote:
> Can you either file a bug for removing these dependencies, or reference
another
> bug about removing them, and put the bug in the comment here?

Done.

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:103:
'<(DEPTH)/third_party/WebKit/public/blink.gyp:blink',
On 2014/04/03 20:06:45, James Cook wrote:
> nit: alphabetize above

Done.

[Ken Rockot(use gerrit already), 2014-04-03 20:13:58]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-04-03 20:21:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/223613005/20001

[Yoyo Zhou, 2014-04-03 21:29:59]

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp
File apps/shell/app_shell.gyp (right):

https://codereview.chromium.org/223613005/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:52: # In this case, "temporary" means until the
//extensions houses all code
nit: extraneous "the"?

[Yoyo Zhou, 2014-04-03 21:30:06]

meant to LGTM

[commit-bot: I haz the power, 2014-04-03 22:52:14]

Change committed as 261559