Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Unified Diff: blimp/client/core/blimp_client_context_impl.h

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai
Patch Set: Addresses kmarshall's #16 comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/blimp_client_context_impl.h
diff --git a/blimp/client/core/blimp_client_context_impl.h b/blimp/client/core/blimp_client_context_impl.h
index 86c3cc8bee4ccca718081e240a4d305612f7e67f..9d8550b828af511ebc54e4c537f00f920d218d7f 100644
--- a/blimp/client/core/blimp_client_context_impl.h
+++ b/blimp/client/core/blimp_client_context_impl.h
@@ -6,6 +6,7 @@
#define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
#include <memory>
+#include <string>
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -74,6 +75,9 @@ class BlimpClientContextImpl : public BlimpClientContext,
std::unique_ptr<BlimpContentsManager> blimp_contents_manager_;
+ // TODO(lethalantidote): Add unique_ptr to GeolocationFeature and
+ // register it.
Wez 2016/08/24 23:07:18 Not clear what this means - why not do that now? O
CJ 2016/08/25 19:08:22 I can file a bug, sure. Kmarshall suggested that w
+
// Container struct for network components.
// Must be deleted on the IO thread.
std::unique_ptr<ClientNetworkComponents> net_components_;

Powered by Google App Engine
This is Rietveld 408576698