Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Side by Side Diff: blimp/client/core/blimp_client_context_impl.h

Issue 2249283003: Hooks together Geolocation Feature in the Client and Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lai
Patch Set: Addresses kmarshall's #16 comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 5 #ifndef BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
6 #define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 6 #define BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string>
9 10
10 #include "base/macros.h" 11 #include "base/macros.h"
11 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
12 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
13 #include "base/single_thread_task_runner.h" 14 #include "base/single_thread_task_runner.h"
14 #include "base/threading/thread.h" 15 #include "base/threading/thread.h"
15 #include "blimp/client/core/session/client_network_components.h" 16 #include "blimp/client/core/session/client_network_components.h"
16 #include "blimp/client/core/session/network_event_observer.h" 17 #include "blimp/client/core/session/network_event_observer.h"
17 #include "blimp/client/public/blimp_client_context.h" 18 #include "blimp/client/public/blimp_client_context.h"
18 #include "blimp/client/public/contents/blimp_contents.h" 19 #include "blimp/client/public/contents/blimp_contents.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 68
68 // The task runner to use for file operations. 69 // The task runner to use for file operations.
69 scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner_; 70 scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner_;
70 71
71 // The AssignmentSource is used when the user of BlimpClientContextImpl calls 72 // The AssignmentSource is used when the user of BlimpClientContextImpl calls
72 // Connect() to get a valid assignment and later connect to the engine. 73 // Connect() to get a valid assignment and later connect to the engine.
73 std::unique_ptr<AssignmentSource> assignment_source_; 74 std::unique_ptr<AssignmentSource> assignment_source_;
74 75
75 std::unique_ptr<BlimpContentsManager> blimp_contents_manager_; 76 std::unique_ptr<BlimpContentsManager> blimp_contents_manager_;
76 77
78 // TODO(lethalantidote): Add unique_ptr to GeolocationFeature and
79 // register it.
Wez 2016/08/24 23:07:18 Not clear what this means - why not do that now? O
CJ 2016/08/25 19:08:22 I can file a bug, sure. Kmarshall suggested that w
80
77 // Container struct for network components. 81 // Container struct for network components.
78 // Must be deleted on the IO thread. 82 // Must be deleted on the IO thread.
79 std::unique_ptr<ClientNetworkComponents> net_components_; 83 std::unique_ptr<ClientNetworkComponents> net_components_;
80 84
81 std::unique_ptr<ThreadPipeManager> thread_pipe_manager_; 85 std::unique_ptr<ThreadPipeManager> thread_pipe_manager_;
82 86
83 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_; 87 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_;
84 88
85 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl); 89 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl);
86 }; 90 };
87 91
88 } // namespace client 92 } // namespace client
89 } // namespace blimp 93 } // namespace blimp
90 94
91 #endif // BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_ 95 #endif // BLIMP_CLIENT_CORE_BLIMP_CLIENT_CONTEXT_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698