Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2249203002: Revert of Better pack fields in Variable (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Better pack fields in Variable (patchset #1 id:1 of https://codereview.chromium.org/2253513002/ ) Reason for revert: Revert: Breaks ARM build: https://uberchromegw.corp.google.com/i/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/2999 Original issue's description: > Better pack fields in Variable > > This reduces sizeof(Variable) from 64 to 40 on x64 > > BUG=v8:5209 > > Committed: https://crrev.com/d84343568047c8621a6b8f88f20a7f34586321b8 > Cr-Commit-Position: refs/heads/master@{#38659} TBR=marja@chromium.org,jkummerow@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5209 Committed: https://crrev.com/e7ccf0c297e95c844f88576d425558ca5b79d67e Cr-Commit-Position: refs/heads/master@{#38666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -38 lines) Patch
M src/ast/variables.h View 2 chunks +11 lines, -21 lines 0 comments Download
M src/ast/variables.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/globals.h View 5 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Hablich
Created Revert of Better pack fields in Variable
4 years, 4 months ago (2016-08-16 18:21:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249203002/1
4 years, 4 months ago (2016-08-16 18:21:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 18:21:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e7ccf0c297e95c844f88576d425558ca5b79d67e Cr-Commit-Position: refs/heads/master@{#38666}
4 years, 4 months ago (2016-08-16 18:22:04 UTC) #6
JaideepBajwa
4 years, 4 months ago (2016-08-16 20:52:13 UTC) #8
Message was sent while issue was closed.
Hi, I was looking at this failure as it was affecting ppc/s390 native builds too
(which uses gcc to build). It seems to be failing because of this GCC bug
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414

Powered by Google App Engine
This is Rietveld 408576698