Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2249063004: Add first party sites (PLUS, INBOX, DOCS) in ServiceWorkerSite UMA. (Closed)

Created:
4 years, 4 months ago by horo
Modified:
4 years, 4 months ago
Reviewers:
Mark P, shimazu
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, asvitkine+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add first party sites (PLUS, INBOX, DOCS) in ServiceWorkerSite UMA. This CL depends on https://codereview.chromium.org/2250623003/. https://codereview.chromium.org/2218943002/ depends on this CL. BUG=561209 Committed: https://crrev.com/9b4b3efc524314409d7fe235f77947d0e6a6b7b1 Cr-Commit-Position: refs/heads/master@{#413638}

Patch Set 1 : all #

Patch Set 2 : diff from https://codereview.chromium.org/2250623003/#ps120001 #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : incorporated mpearson@'s comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_metrics.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
horo
shimazu@ Could you please review this?
4 years, 4 months ago (2016-08-17 06:49:30 UTC) #6
shimazu
lgtm
4 years, 4 months ago (2016-08-18 04:49:06 UTC) #9
horo
mpearson@ Could you please review histograms.xml?
4 years, 4 months ago (2016-08-22 06:12:03 UTC) #13
Mark P
histograms.xml lgtm https://codereview.chromium.org/2249063004/diff/60001/content/browser/service_worker/service_worker_metrics.cc File content/browser/service_worker/service_worker_metrics.cc (right): https://codereview.chromium.org/2249063004/diff/60001/content/browser/service_worker/service_worker_metrics.cc#newcode218 content/browser/service_worker/service_worker_metrics.cc:218: if (host == "docs.google.com" || host == ...
4 years, 4 months ago (2016-08-22 17:00:53 UTC) #16
horo
Thank you!
4 years, 4 months ago (2016-08-22 23:14:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249063004/80001
4 years, 4 months ago (2016-08-22 23:15:05 UTC) #20
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 4 months ago (2016-08-23 02:34:17 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 02:35:12 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9b4b3efc524314409d7fe235f77947d0e6a6b7b1
Cr-Commit-Position: refs/heads/master@{#413638}

Powered by Google App Engine
This is Rietveld 408576698