Linux: Add libbluetooth to sysroot scripts

Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.

BUG=638394
Committed: https://crrev.com/d61be279532de3e797906b26cdbb00516703dd31
Cr-Commit-Position: refs/heads/master@{#412397}

[Tom (Use chromium acct), 2016-08-16 20:57:26]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 20:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2016-08-16 20:59:23]

Description was changed from

==========
Add libbluetooth to sysroot scripts
==========

to

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well. 
Finally, added to trusty sysroot for good measure.
==========

[Tom (Use chromium acct), 2016-08-16 20:59:23]

thomasanderson@google.com changed reviewers:
+ thestig@chromium.org

[Tom (Use chromium acct), 2016-08-16 21:01:05]

Description was changed from

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well. 
Finally, added to trusty sysroot for good measure.
==========

to

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.
==========

[Tom (Use chromium acct), 2016-08-16 21:29:27]

thomasanderson@google.com changed reviewers:
+ dpranke@chromium.org

[Tom (Use chromium acct), 2016-08-16 21:29:28]

+ dpranke@ for review
thestig@ for OWNERS

[commit-bot: I haz the power, 2016-08-16 21:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 21:45:56]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-08-16 22:13:10]

dpranke@chromium.org changed reviewers:
+ ortuno@chromium.org

[Dirk Pranke, 2016-08-16 22:14:23]

+ortuno as a bluetooth person ...

I'm a little nervous about adding something like this. Are you sure that the
needed bluetooth lib is normally there on a wheezy install, and we're not
introducing a runtime dependency on desktop linux that will cause problems?

[Dirk Pranke, 2016-08-16 22:20:24]

Description was changed from

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.
==========

to

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.

BUG=638394
==========

[Dirk Pranke, 2016-08-16 22:20:40]

(adding link to the motivating bug for context).

[ortuno, 2016-08-16 22:52:21]

What's "Desktop Chromium OS"?

[Dirk Pranke, 2016-08-16 23:25:40]

On 2016/08/16 22:52:21, ortuno wrote:
> What's "Desktop Chromium OS"?

A linux build with `target_os="chromeos"`. I.e., you compile Chromium as if
you're targetting CrOS, but the binary will actually run on your linux host.

We don't actually have a name for this configuration that I know of, but I call
it that.

[ortuno, 2016-08-16 23:40:16]

ortuno@chromium.org changed reviewers:
+ rkc@chromium.org

[ortuno, 2016-08-16 23:40:16]

+rkc who knows more about Chrome OS.

If the objective is just to compile then I think this might be OK. fwiw: Chrome
OS uses a modified copy of the latest BlueZ version and that is always changing.
Besides the differences between the Chrome OS and upstream versions, there are
some differences between each BlueZ version so you might be able to link against
libbluetooth3-5.34 on jessie but fail against libbluetooth3-4.101 on trusty.
That said, I've always been able to link against 4.101 (which is pretty old) on
trusty so it's probably OK.

[rkc, 2016-08-16 23:52:03]

Where are we using libbluetooth from?

[Tom (Use chromium acct), 2016-08-16 23:53:25]

On 2016/08/16 23:52:03, rkc wrote:
> Where are we using libbluetooth from?

https://cs.chromium.org/chromium/src/components/arc/bluetooth/arc_bluetooth_b...

[Tom (Use chromium acct), 2016-08-16 23:56:33]

On 2016/08/16 22:14:23, Dirk Pranke wrote:
> +ortuno as a bluetooth person ...
> 
> I'm a little nervous about adding something like this. Are you sure that the
> needed bluetooth lib is normally there on a wheezy install, and we're not
> introducing a runtime dependency on desktop linux that will cause problems?

I don't think that should be a problem.  If there was a runtime dependency on
libbluetooth before, updating the sysroot wouldn't break it, right? (as long as
the libraries are ABI compatible)

[rkc, 2016-08-17 00:00:52]

rkc@chromium.org changed reviewers:
+ lhchavez@chromium.org

[rkc, 2016-08-17 00:00:53]

So we should 'not' have a runtime dependency on libbluetooth. That code should
only require the header for Bluetooth to use the correct enums for the socket
call.

What exactly does adding this library to the sysroot do? Does it just make the
headers available or does it compile Chrome with libbluetooth also?

[Tom (Use chromium acct), 2016-08-17 00:02:31]

On 2016/08/17 00:00:53, rkc wrote:
> So we should 'not' have a runtime dependency on libbluetooth. That code should
> only require the header for Bluetooth to use the correct enums for the socket
> call.
> 
> What exactly does adding this library to the sysroot do? Does it just make the
> headers available or does it compile Chrome with libbluetooth also?

It makes the headers available.  Builds will only link against libbluetooth if
they did before, and the library linked in will be the sysroot one, not the
system one.

[rkc, 2016-08-17 00:10:10]

Ah, lgtm then.
I am not particularly happy about using libbluetooth headers in Chrome - but I
can live with it for now since we don't have a better solution for providing BT
RFComm on ARC++.

[Lei Zhang, 2016-08-17 00:26:26]

lgtm

[Tom (Use chromium acct), 2016-08-17 00:30:30]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-08-17 00:30:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 00:34:55]

Description was changed from

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.

BUG=638394
==========

to

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.

BUG=638394
==========

[commit-bot: I haz the power, 2016-08-17 00:34:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 00:36:28]

Description was changed from

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.

BUG=638394
==========

to

==========
Add libbluetooth to sysroot scripts

Desktop Chromium OS is unable to build with the current wheezy sysroot because
it is missing libbluetooth-dev.

This CL adds libbluetooth to the wheezy sysroot.  Eventually we will want to
build Chromium OS with the jessie sysroot, so added libbluetooth there as well.
Finally, added to trusty sysroot for good measure.

BUG=638394

Committed: https://crrev.com/d61be279532de3e797906b26cdbb00516703dd31
Cr-Commit-Position: refs/heads/master@{#412397}
==========

[commit-bot: I haz the power, 2016-08-17 00:36:29]

Patchset 1 (id:??) landed as
https://crrev.com/d61be279532de3e797906b26cdbb00516703dd31
Cr-Commit-Position: refs/heads/master@{#412397}

[Dirk Pranke, 2016-08-17 00:47:42]

lgtm