content/public/browser/page_navigator.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/page_navigator.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/page_navigator.cc

diff --git a/content/public/browser/page_navigator.cc b/content/public/browser/page_navigator.cc

index 40225e1aae83ae8da639505a4c8cec658d2e8757..e8a61bbfb6d683cc8afe82210979a44f5561dc2e 100644

--- a/content/public/browser/page_navigator.cc

+++ b/content/public/browser/page_navigator.cc

@@ -44,12 +44,11 @@ OpenURLParams::OpenURLParams(

OpenURLParams::OpenURLParams()

: uses_post(false),

frame_tree_node_id(-1),

- disposition(UNKNOWN),

+ disposition(WindowOpenDisposition::UNKNOWN),

transition(ui::PAGE_TRANSITION_LINK),

is_renderer_initiated(false),

should_replace_current_entry(false),

- user_gesture(true) {

+ user_gesture(true) {}

OpenURLParams::OpenURLParams(const OpenURLParams& other) = default;