content/browser/webui/generic_handler.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/generic_handler.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/webui/generic_handler.cc

diff --git a/content/browser/webui/generic_handler.cc b/content/browser/webui/generic_handler.cc

index b26bcd9294a3232e2c4738a4f94596d9c0d9d52e..71259a8066afc74a7a35a869ffc060188cd1ab39 100644

--- a/content/browser/webui/generic_handler.cc

+++ b/content/browser/webui/generic_handler.cc

@@ -47,8 +47,9 @@ void GenericHandler::HandleNavigateToUrl(const base::ListValue* args) {

WindowOpenDisposition disposition = ui::DispositionFromClick(

middle_button, alt_key, ctrl_key, meta_key, shift_key);

- if (disposition == CURRENT_TAB && target_string == "_blank")

- disposition = NEW_FOREGROUND_TAB;

+ if (disposition == WindowOpenDisposition::CURRENT_TAB &&

+ target_string == "_blank")

+ disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

web_ui()->GetWebContents()->OpenURL(OpenURLParams(GURL(url_string),

Referrer(),