chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/website_settings_popup_view.cc ('k') | chrome/browser/ui/webui/chrome_web_contents_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc b/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc

index 25b46b7a8560ce20ae46fc8c3414e43b96383163..bfc40de79986c6e1dd65d1162853f6df89d7a591 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc

@@ -42,9 +42,9 @@ Browser* PermissionBubbleBrowserTest::OpenExtensionAppWindow() {

LoadExtension(test_data_dir_.AppendASCII("app_with_panel_container/"));

CHECK(extension);

- AppLaunchParams params(browser()->profile(), extension,

- extensions::LAUNCH_CONTAINER_PANEL, NEW_WINDOW,

- extensions::SOURCE_TEST);

+ AppLaunchParams params(

+ browser()->profile(), extension, extensions::LAUNCH_CONTAINER_PANEL,

+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST);

content::WebContents* app_window = OpenApplication(params);

CHECK(app_window);