chrome/browser/memory/tab_manager_observer_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory/tab_manager_observer_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory/tab_manager_observer_browsertest.cc

diff --git a/chrome/browser/memory/tab_manager_observer_browsertest.cc b/chrome/browser/memory/tab_manager_observer_browsertest.cc

index 403b6da48efb785f37695594f3d63add85d5b251..d8a1749df67fe4b5a741d6384c2b434ae83f7ed8 100644

--- a/chrome/browser/memory/tab_manager_observer_browsertest.cc

+++ b/chrome/browser/memory/tab_manager_observer_browsertest.cc

@@ -88,11 +88,13 @@ IN_PROC_BROWSER_TEST_F(TabManagerObserverTest, OnDiscardStateChange) {

// Open two tabs.

OpenURLParams open1(GURL(chrome::kChromeUIAboutURL), content::Referrer(),

- NEW_BACKGROUND_TAB, ui::PAGE_TRANSITION_TYPED, false);

+ WindowOpenDisposition::NEW_BACKGROUND_TAB,

+ ui::PAGE_TRANSITION_TYPED, false);

int index_1 = GetIndex(browser()->OpenURL(open1));

OpenURLParams open2(GURL(chrome::kChromeUICreditsURL), content::Referrer(),

- NEW_BACKGROUND_TAB, ui::PAGE_TRANSITION_TYPED, false);

+ WindowOpenDisposition::NEW_BACKGROUND_TAB,

+ ui::PAGE_TRANSITION_TYPED, false);

int index_2 = GetIndex(browser()->OpenURL(open2));

// Subscribe observer to TabManager's observer list.

@@ -150,7 +152,8 @@ IN_PROC_BROWSER_TEST_F(TabManagerObserverTest, OnAutoDiscardableStateChange) {

// Open two tabs.

OpenURLParams open(GURL(chrome::kChromeUIAboutURL), content::Referrer(),

- NEW_BACKGROUND_TAB, ui::PAGE_TRANSITION_TYPED, false);

+ WindowOpenDisposition::NEW_BACKGROUND_TAB,

+ ui::PAGE_TRANSITION_TYPED, false);

WebContents* contents = browser()->OpenURL(open);

// Subscribe observer to TabManager's observer list.